Skip to content

Commit a5dfbe1

Browse files
authored
chore: add default timeout to make (#593)
Signed-off-by: Todd Baert <[email protected]>
1 parent f6a154d commit a5dfbe1

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Makefile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ KUSTOMIZE_OVERLAY ?= DEFAULT
99
CHART_VERSION=v0.5.2# x-release-please-version
1010
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
1111
ENVTEST_K8S_VERSION = 1.26.1
12+
WAIT_TIMEOUT_SECONDS?=60
1213

1314
# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
1415
ifeq (,$(shell go env GOBIN))
@@ -169,9 +170,9 @@ undeploy: generate ## Undeploy controller from the K8s cluster specified in ~/.k
169170
deploy-operator:
170171
kubectl create ns 'open-feature-operator-system' --dry-run=client -o yaml | kubectl apply -f -
171172
kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.11.0/cert-manager.yaml
172-
kubectl wait --for=condition=Available=True deploy --all -n 'cert-manager'
173+
kubectl wait --for=condition=Available=True deploy --all -n 'cert-manager' --timeout=$(WAIT_TIMEOUT_SECONDS)s
173174
make deploy
174-
kubectl wait --for=condition=Available=True deploy --all -n 'open-feature-operator-system'
175+
kubectl wait --for=condition=Available=True deploy --all -n 'open-feature-operator-system' --timeout=$(WAIT_TIMEOUT_SECONDS)s
175176

176177
.PHONY: build-deploy-operator
177178
build-deploy-operator:
@@ -181,7 +182,7 @@ build-deploy-operator:
181182

182183
deploy-demo:
183184
kubectl apply -f https://raw.githubusercontent.com/open-feature/playground/main/config/k8s/end-to-end.yaml
184-
kubectl wait -l app=open-feature-demo --for=condition=Available=True deploy
185+
kubectl wait -l app=open-feature-demo --for=condition=Available=True deploy --timeout=$(WAIT_TIMEOUT_SECONDS)s
185186
kubectl port-forward service/open-feature-demo-service 30000:30000
186187

187188
delete-demo-deployment:

0 commit comments

Comments
 (0)