feat(flagd): add support for azure blob

 - fix for ToEnvVars function to not add prefix for Azure blob related env vars

Signed-off-by: vmai <[email protected]>

Author: VMaievskyi

api/core/v1beta1/featureflagsource_types.go

@@ -18,6 +18,7 @@ package v1beta1
 
 import (
 	"fmt"
+	"strings"
 
 	"github.com/open-feature/open-feature-operator/apis/core/v1beta1/common"
 	corev1 "k8s.io/api/core/v1"
@@ -209,12 +210,19 @@ func (fc *FeatureFlagSourceSpec) Merge(new *FeatureFlagSourceSpec) {
 	}
 }
 
+func (fc *FeatureFlagSourceSpec) decorateEnvVarName(original string) string {
+	if strings.HasPrefix(original, "AZURE_STORAGE") {
+		return original
+	}
+	return common.EnvVarKey(fc.EnvVarPrefix, original)
+}
+
 func (fc *FeatureFlagSourceSpec) ToEnvVars() []corev1.EnvVar {
 	envs := []corev1.EnvVar{}
 
 	for _, envVar := range fc.EnvVars {
 		envs = append(envs, corev1.EnvVar{
-			Name:  common.EnvVarKey(fc.EnvVarPrefix, envVar.Name),
+			Name:  fc.decorateEnvVarName(envVar.Name),
 			Value: envVar.Value,
 		})
 	}

api/core/v1beta1/featureflagsource_types_test.go

@@ -180,6 +180,14 @@ func Test_FLagSourceConfiguration_ToEnvVars(t *testing.T) {
 					Name:  "env2",
 					Value: "val2",
 				},
+				{
+					Name:  "AZURE_STORAGE_ACCOUNT",
+					Value: "account123",
+				},
+				{
+					Name:  "AZURE_STORAGE_KEY",
+					Value: "key456",
+				},
 			},
 			EnvVarPrefix:   "PRE",
 			ManagementPort: 22,
@@ -198,6 +206,14 @@ func Test_FLagSourceConfiguration_ToEnvVars(t *testing.T) {
 			Name:  "PRE_env2",
 			Value: "val2",
 		},
+		{
+			Name:  "AZURE_STORAGE_ACCOUNT",
+			Value: "account123",
+		},
+		{
+			Name:  "AZURE_STORAGE_KEY",
+			Value: "key456",
+		},
 		{
 			Name:  "PRE_MANAGEMENT_PORT",
 			Value: "22",

chart/open-feature-operator/values.yaml

@@ -41,7 +41,6 @@ sidecarConfiguration:
   ## @param sidecarConfiguration.providerArgs Used to append arguments to the sidecar startup command. This value is a comma separated string of key values separated by '=', e.g. `key=value,key2=value2` results in the appending of `--sync-provider-args key=value --sync-provider-args key2=value2`.
   providerArgs: ""
   ## @param sidecarConfiguration.envVarPrefix Sets the prefix for all environment variables set in the injected sidecar.
-  ## Needs to be empty to support azblob sync type
   envVarPrefix: "FLAGD"
   ## @param sidecarConfiguration.defaultSyncProvider Sets the value of the `XXX_SYNC_PROVIDER` environment variable for the injected sidecar container. There are 4 valid sync providers: `kubernetes`, `grpc`, `file` and `http`.
   defaultSyncProvider: kubernetes

docs/feature_flag_source.md

@@ -91,7 +91,6 @@ Given below is an example configuration with provider type `azblob` and supporte
 sources:
   - source: azblob://my-bucket/test.json # my-bucket - container name
     provider: azblob
-  envVarPrefix: "" # MUST be empty to prevent adding prefix to next env vars
   envVars:
     - name: AZURE_STORAGE_ACCOUNT
       value: <account_name>