fixes issue with credentials (#33)

* fixes issue with credentials

* ignored the kustomisation

Author: AlexsJones

.gitignore

@@ -1,3 +1,4 @@
+config/manager/kustomization.yaml
 .vscode
 open-feature-operator
 of-agent

apis/core/v1alpha1/featureflagconfiguration_types.go

@@ -30,15 +30,18 @@ type FeatureFlagConfigurationSpec struct {
 	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
 	// Important: Run "make" to regenerate code after modifying this file
 	// +optional
+	// +nullable
 	Provider *FeatureFlagProvider `json:"provider"`
 	// FeatureFlagSpec is the json representation of the feature flag
 	FeatureFlagSpec string `json:"featureFlagSpec,omitempty"`
 }
 
 type FeatureFlagProvider struct {
 	// +kubebuilder:validation:Enum=flagD
-	Name        string                 `json:"name"`
-	Credentials corev1.ObjectReference `json:"credentials"`
+	Name string `json:"name"`
+	// +optional
+	// +nullable
+	Credentials *corev1.ObjectReference `json:"credentials"`
 }
 
 // FeatureFlagConfigurationStatus defines the observed state of FeatureFlagConfiguration

apis/core/v1alpha1/zz_generated.deepcopy.go

@@ -44,6 +44,7 @@ spec:
               provider:
                 description: 'INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
                   Important: Run "make" to regenerate code after modifying this file'
+                nullable: true
                 properties:
                   credentials:
                     description: 'ObjectReference contains enough information to let
@@ -71,6 +72,7 @@ spec:
                       that is well-focused on your reference. For example, ServiceReferences
                       for admission registration: https://github.com/kubernetes/api/blob/release-1.17/admissionregistration/v1/types.go#L533
                       .'
+                    nullable: true
                     properties:
                       apiVersion:
                         description: API version of the referent.
@@ -110,7 +112,6 @@ spec:
                     - flagD
                     type: string
                 required:
-                - credentials
                 - name
                 type: object
             type: object

config/crd/bases/core.openfeature.dev_featureflagconfigurations.yaml

@@ -1,16 +1,16 @@
 resources:
-  - manager.yaml
+- manager.yaml
 
 generatorOptions:
   disableNameSuffixHash: true
 
 configMapGenerator:
-  - files:
-      - controller_manager_config.yaml
-    name: manager-config
+- files:
+  - controller_manager_config.yaml
+  name: manager-config
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 images:
-  - name: controller
-    newName: controller
-    newTag: latest
+- name: controller
+  newName: controller
+  newTag: latest

config/manager/kustomization.yaml

@@ -48,7 +48,7 @@ func (m *FeatureFlagConfigurationValidator) Handle(ctx context.Context, req admi
 		}
 	}
 
-	if config.Spec.Provider.Credentials.Name != "" {
+	if config.Spec.Provider != nil && config.Spec.Provider.Credentials != nil {
 		// Check the provider and whether it has an existing secret
 		providerKeySecret := corev1.Secret{}
 		if err := m.Client.Get(ctx, client.ObjectKey{Name: config.Spec.Provider.Credentials.Name,