-
Notifications
You must be signed in to change notification settings - Fork 91
feat: add YouTube video embed to homepage #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add YouTube video embed to homepage #1313
Conversation
Added OpenFeature Fundamentals YouTube video to the homepage, positioned between QuestionBlocks and FeaturesZigZag sections. Extracted video embed as a reusable partial component. Signed-off-by: Pete Hodgson <[email protected]>
Summary of ChangesHello @moredip, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the homepage by integrating a YouTube video, specifically the "OpenFeature Fundamentals" content. It introduces a new, flexible Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a reusable VideoEmbed component to display a YouTube video on the homepage. The implementation is clean and uses react-lite-youtube-embed for improved performance. My feedback focuses on enhancing accessibility by making the title prop on the VideoEmbed component mandatory, ensuring a descriptive title is always provided for screen reader users.
I noticed that we had this really nice short video overview, and thought it would be good to add to the homepage. - Added OpenFeature Fundamentals YouTube video embed to the homepage, positioned between QuestionBlocks and FeaturesZigZag sections. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Pete Hodgson <[email protected]>
I noticed that we had this really nice short video overview, and thought it would be good to add to the homepage.
🤖 Generated with Claude Code