Skip to content

Commit 14c85b5

Browse files
committed
fix CR comments
Signed-off-by: gruebel <[email protected]>
1 parent 0f1bade commit 14c85b5

File tree

2 files changed

+7
-13
lines changed
  • providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers

2 files changed

+7
-13
lines changed

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,9 @@ def emit_error(self) -> None:
222222

223223
def listen(self) -> None:
224224
logger.debug("gRPC starting listener thread")
225-
call_args: GrpcMultiCallableArgs = (
226-
{"timeout": self.streamline_deadline_seconds}
227-
if self.streamline_deadline_seconds > 0
228-
else {}
229-
)
230-
call_args["wait_for_ready"] = True
225+
call_args: GrpcMultiCallableArgs = {"wait_for_ready": True}
226+
if self.streamline_deadline_seconds > 0:
227+
call_args["timeout"] = self.streamline_deadline_seconds
231228
request = evaluation_pb2.EventStreamRequest()
232229

233230
# defining a never ending loop to recreate the stream

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -229,13 +229,10 @@ def _fetch_metadata(self) -> typing.Optional[sync_pb2.GetMetadataResponse]:
229229
else:
230230
raise e
231231

232-
def listen(self) -> None:
233-
call_args: GrpcMultiCallableArgs = (
234-
{"timeout": self.streamline_deadline_seconds}
235-
if self.streamline_deadline_seconds > 0
236-
else {}
237-
)
238-
call_args["wait_for_ready"] = True
232+
def listen(self) -> None: # noqa: C901
233+
call_args: GrpcMultiCallableArgs = {"wait_for_ready": True}
234+
if self.streamline_deadline_seconds > 0:
235+
call_args["timeout"] = self.streamline_deadline_seconds
239236
request_args = self._create_request_args()
240237

241238
while self.active:

0 commit comments

Comments
 (0)