feat(provider): resolve_boolean_details honors default_value

Signed-off-by: Kiki L Hakiem <[email protected]>

Author: kikihakiem

providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py

@@ -54,8 +54,13 @@ def resolve_boolean_details(
         Returns:
             FlagResolutionDetails with the resolved boolean value
         """
+
         context = self._provider._build_unleash_context(evaluation_context)
-        is_enabled = self._provider.client.is_enabled(flag_key, context=context)
+        is_enabled = self._provider.client.is_enabled(
+            flag_key,
+            context=context,
+            fallback_function=self._fallback_function(default_value),
+        )
 
         return FlagResolutionDetails(
             value=is_enabled,
@@ -224,3 +229,11 @@ def _parse_json(self, value: Any) -> Any:
             except json.JSONDecodeError as e:
                 raise ParseError(f"Invalid JSON: {e}") from e
         return value
+
+    def _fallback_function(self, default_value: bool) -> Callable:
+        """Default fallback function for Unleash provider."""
+
+        def fallback_function(feature_name: str, context: dict) -> bool:
+            return default_value
+
+        return fallback_function

providers/openfeature-provider-unleash/tests/test_flag_evaluation.py

@@ -1,8 +1,9 @@
 """Tests for flag evaluation functionality."""
 
-from unittest.mock import Mock, patch
+from unittest.mock import ANY, Mock, patch
 
 import pytest
+from UnleashClient.cache import FileCache
 
 from openfeature.contrib.provider.unleash import UnleashProvider
 from openfeature.evaluation_context import EvaluationContext
@@ -34,6 +35,29 @@ def test_resolve_boolean_details():
         assert flag.reason == Reason.TARGETING_MATCH
 
 
+def test_resolve_boolean_details_with_true_default():
+    """Ensure default_value is used when engine returns None (fallback)."""
+    # Create a real client via the provider, but prevent network fetches
+    custom_cache = FileCache("test-app")
+    custom_cache.bootstrap_from_dict({})
+    provider = UnleashProvider(
+        url="http://invalid-host.local",  # won't be used since we disable fetch
+        app_name="test-app",
+        api_token="test-token",
+        fetch_toggles=False,
+        cache=custom_cache,
+    )
+
+    provider.initialize()
+
+    try:
+        result = provider.resolve_boolean_details("test_flag", True)
+        assert result.value is True  # uses the default value via fallback
+        assert result.reason == Reason.TARGETING_MATCH
+    finally:
+        provider.shutdown()
+
+
 @pytest.mark.parametrize(
     "method_name, payload_value, expected_value, default_value",
     [
@@ -105,6 +129,7 @@ def test_with_evaluation_context():
         mock_client.is_enabled.assert_called_with(
             "test_flag",
             context={"userId": "user123", "email": "[email protected]", "country": "US"},
+            fallback_function=ANY,
         )
 
         provider.shutdown()