refactor(provider): remove unused exception handling

Signed-off-by: Kiki L Hakiem <[email protected]>

Author: kikihakiem

providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/__init__.py

@@ -99,18 +99,9 @@ def get_provider_hooks(self) -> list[Hook]:
 
     def shutdown(self) -> None:
         """Shutdown the Unleash client."""
-        try:
-            if self.client.is_initialized:
-                self.client.destroy()
-            self._status = ProviderStatus.NOT_READY
-        except Exception as e:
-            self._status = ProviderStatus.ERROR
-            self._event_manager.emit_event(
-                ProviderEvent.PROVIDER_ERROR,
-                error_message=str(e),
-                error_code=ErrorCode.GENERAL,
-            )
-            raise GeneralError(f"Failed to shutdown Unleash provider: {e}") from e
+        if self.client.is_initialized:
+            self.client.destroy()
+        self._status = ProviderStatus.NOT_READY
 
     def on_context_changed(
         self,

providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py

@@ -7,7 +7,6 @@
 
 from openfeature.evaluation_context import EvaluationContext
 from openfeature.exception import (
-    GeneralError,
     ParseError,
     TypeMismatchError,
 )
@@ -55,26 +54,21 @@ def resolve_boolean_details(
         Returns:
             FlagResolutionDetails with the resolved boolean value
         """
-        try:
-            context = self._provider._build_unleash_context(evaluation_context)
-            is_enabled = self._provider.client.is_enabled(flag_key, context=context)
-
-            return FlagResolutionDetails(
-                value=is_enabled,
-                reason=Reason.TARGETING_MATCH if is_enabled else Reason.DEFAULT,
-                variant=None,
-                error_code=None,
-                error_message=None,
-                flag_metadata={
-                    "source": "unleash",
-                    "enabled": is_enabled,
-                    "app_name": self._provider.app_name,
-                },
-            )
-        except (TypeMismatchError, ParseError, GeneralError):
-            raise
-        except Exception as e:
-            raise GeneralError(f"Unexpected error: {e}") from e
+        context = self._provider._build_unleash_context(evaluation_context)
+        is_enabled = self._provider.client.is_enabled(flag_key, context=context)
+
+        return FlagResolutionDetails(
+            value=is_enabled,
+            reason=Reason.TARGETING_MATCH if is_enabled else Reason.DEFAULT,
+            variant=None,
+            error_code=None,
+            error_message=None,
+            flag_metadata={
+                "source": "unleash",
+                "enabled": is_enabled,
+                "app_name": self._provider.app_name,
+            },
+        )
 
     def resolve_string_details(
         self,
@@ -174,48 +168,43 @@ def _resolve_variant_flag(
         Returns:
             FlagResolutionDetails with the resolved value
         """
-        try:
-            context = self._provider._build_unleash_context(evaluation_context)
-            variant = self._provider.client.get_variant(flag_key, context=context)
-
-            if variant.get("enabled", False) and "payload" in variant:
-                try:
-                    payload_value = variant["payload"].get("value", default_value)
-                    value = value_converter(payload_value)
-                    return FlagResolutionDetails(
-                        value=value,
-                        reason=Reason.TARGETING_MATCH,
-                        variant=variant.get("name"),
-                        error_code=None,
-                        error_message=None,
-                        flag_metadata={
-                            "source": "unleash",
-                            "enabled": variant.get("enabled", False),
-                            "variant_name": variant.get("name") or "",
-                            "app_name": self._provider.app_name,
-                        },
-                    )
-                except (ValueError, TypeError) as e:
-                    raise TypeMismatchError(str(e)) from e
-                except ParseError:
-                    raise
-            else:
+        context = self._provider._build_unleash_context(evaluation_context)
+        variant = self._provider.client.get_variant(flag_key, context=context)
+
+        if variant.get("enabled", False) and "payload" in variant:
+            try:
+                payload_value = variant["payload"].get("value", default_value)
+                value = value_converter(payload_value)
                 return FlagResolutionDetails(
-                    value=default_value,
-                    reason=Reason.DEFAULT,
-                    variant=None,
+                    value=value,
+                    reason=Reason.TARGETING_MATCH,
+                    variant=variant.get("name"),
                     error_code=None,
                     error_message=None,
                     flag_metadata={
                         "source": "unleash",
                         "enabled": variant.get("enabled", False),
+                        "variant_name": variant.get("name") or "",
                         "app_name": self._provider.app_name,
                     },
                 )
-        except (TypeMismatchError, ParseError, GeneralError):
-            raise
-        except Exception as e:
-            raise GeneralError(f"Unexpected error: {e}") from e
+            except ValueError as e:
+                raise TypeMismatchError(str(e)) from e
+            except ParseError:
+                raise
+        else:
+            return FlagResolutionDetails(
+                value=default_value,
+                reason=Reason.DEFAULT,
+                variant=None,
+                error_code=None,
+                error_message=None,
+                flag_metadata={
+                    "source": "unleash",
+                    "enabled": variant.get("enabled", False),
+                    "app_name": self._provider.app_name,
+                },
+            )
 
     def _parse_json(self, value: Any) -> Any:
         """Parse JSON value for object flags.

providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/tracking.py

@@ -46,9 +46,6 @@ def track(
             evaluation_context: Optional evaluation context
             event_details: Optional tracking event details
         """
-        if not self._provider.client:
-            return
-
         unleash_context = (
             self._provider._build_unleash_context(evaluation_context) or {}
         )

providers/openfeature-provider-unleash/tests/test_provider.py

@@ -1,13 +1,13 @@
 import uuid
 from unittest.mock import Mock, patch
 
+from UnleashClient.cache import FileCache
 from UnleashClient.events import UnleashEventType, UnleashReadyEvent
 
 from openfeature.contrib.provider.unleash import UnleashProvider
 from openfeature.evaluation_context import EvaluationContext
 from openfeature.provider import ProviderStatus
 
-
 # Mock feature response for testing cache functionality
 MOCK_FEATURE_RESPONSE = {
     "version": 1,
@@ -196,8 +196,6 @@ def test_unleash_provider_flag_metadata():
 
 def test_unleash_provider_with_custom_cache():
     """Test that UnleashProvider properly uses a custom cache with mocked features."""
-    from UnleashClient.cache import FileCache
-
     # Create a custom cache with mocked features
     custom_cache = FileCache("test-app")
     custom_cache.bootstrap_from_dict(MOCK_FEATURE_RESPONSE)