Skip to content

Commit 7bf74e1

Browse files
committed
fix type errors and fmt
Signed-off-by: christian.lutnik <[email protected]>
1 parent 390144d commit 7bf74e1

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/in_process.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@
1818

1919

2020
def _merge_metadata(
21-
flag_metadata: typing.Mapping[str, typing.Union[float, int, str, bool]] | None,
22-
flag_set_metadata: typing.Mapping[str, typing.Union[float, int, str, bool]] | None,
21+
flag_metadata: typing.Optional[typing.Mapping[str, typing.Union[float, int, str, bool]]],
22+
flag_set_metadata: typing.Optional[typing.Mapping[str, typing.Union[float, int, str, bool]]],
2323
) -> typing.Mapping[str, typing.Union[float, int, str, bool]]:
2424
metadata = {}
2525

2626
if flag_set_metadata is not None:
27-
metadata = { key: flag_set_metadata[key] for key in flag_set_metadata.keys() }
27+
metadata = { key: value for key, value in flag_set_metadata }
2828

2929
if flag_metadata is not None:
3030
for key, value in flag_metadata.items():

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/file_watcher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from openfeature.contrib.provider.flagd.resolvers.process.flags import FlagStore
1515
from openfeature.evaluation_context import EvaluationContext
1616
from openfeature.event import ProviderEventDetails
17-
from openfeature.exception import ParseError, ProviderNotReadyError, ErrorCode
17+
from openfeature.exception import ErrorCode, ParseError, ProviderNotReadyError
1818

1919
logger = logging.getLogger("openfeature.contrib")
2020

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,7 @@ def _validate_metadata(key: str, value: typing.Union[float, int, str, bool]) ->
1919
)
2020
if value is None:
2121
raise ParseError("Metadata value for key " + str(key) + " must be set")
22-
elif not (
23-
isinstance(value, float)
24-
or isinstance(value, int)
25-
or isinstance(value, str)
26-
or isinstance(value, bool)
27-
):
22+
elif not isinstance(value, (float, int, str, bool)):
2823
raise ParseError(
2924
"Metadata value "
3025
+ str(value)

providers/openfeature-provider-flagd/tests/test_metadata.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ def test_should_load_flag_combined_metadata():
6868
class Channel:
6969
parse_error_received = False
7070

71+
7172
def create_error_handler():
7273
channel = Channel()
7374

0 commit comments

Comments
 (0)