fix format, add tests

Signed-off-by: christian.lutnik <[email protected]>

Author: chrfwow

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py

@@ -17,6 +17,8 @@ def _validate_metadata(key: str, value: typing.Union[float, int, str, bool]) ->
             + " must be of type str, but is "
             + str(type(key))
         )
+    elif not key:
+        raise ParseError("key must not be empty")
     if value is None:
         raise ParseError("Metadata value for key " + str(key) + " must be set")
     elif not isinstance(value, (float, int, str, bool)):
@@ -110,7 +112,6 @@ def __post_init__(self) -> None:
             for key, value in self.metadata.items():
                 _validate_metadata(key, value)
 
-
     @classmethod
     def from_dict(cls, key: str, data: dict) -> "Flag":
         if "defaultVariant" in data:

providers/openfeature-provider-flagd/tests/test_metadata.py

@@ -8,7 +8,9 @@
 from openfeature.contrib.provider.flagd import FlagdProvider
 from openfeature.contrib.provider.flagd.config import ResolverType
 from openfeature.event import EventDetails, ProviderEvent
-from openfeature.exception import ErrorCode
+from openfeature.exception import ErrorCode, ParseError
+
+from openfeature.contrib.provider.flagd.resolvers.process.flags import _validate_metadata
 
 
 def create_client(file_name):
@@ -103,3 +105,43 @@ def test_invalid_flag_set_metadata(file_name):
         if now - start > max_timeout:
             raise AssertionError()
         sleep(0.01)
+
+
+def test_validate_metadata_with_none_key():
+    try:
+        _validate_metadata(None, "a")
+    except ParseError:
+        return
+    raise AssertionError()
+
+
+def test_validate_metadata_with_empty_key():
+    try:
+        _validate_metadata("", "a")
+    except ParseError:
+        return
+    raise AssertionError()
+
+
+def test_validate_metadata_with_non_string_key():
+    try:
+        _validate_metadata(1, "a")
+    except ParseError:
+        return
+    raise AssertionError()
+
+
+def test_validate_metadata_with_non_string_value():
+    try:
+        _validate_metadata("a", [])
+    except ParseError:
+        return
+    raise AssertionError()
+
+
+def test_validate_metadata_with_none_value():
+    try:
+        _validate_metadata("a", None)
+    except ParseError:
+        return
+    raise AssertionError()