feat(provider): improve type safety

Signed-off-by: Kiki L Hakiem <[email protected]>

Author: kikihakiem

providers/openfeature-provider-unleash/README.md

@@ -1,6 +1,6 @@
 # Unleash Provider for OpenFeature
 
-This provider is designed to use [Unleash](https://unleash.io/).
+This provider is designed to use [Unleash](https://www.getunleash.io/).
 
 ## Installation
 
@@ -18,9 +18,9 @@ from openfeature.contrib.provider.unleash import UnleashProvider
 
 # Initialize the provider with your Unleash configuration
 provider = UnleashProvider(
-    url="https://your-unleash-instance.com",
+    url="https://my-unleash-instance.com",
     app_name="my-python-app",
-    api_token="your-api-token"
+    api_token="my-api-token"
 )
 
 # Initialize the provider (required before use)
@@ -127,7 +127,7 @@ is_enabled = client.get_boolean_value("my-feature", False)
 print(f"Feature is enabled: {is_enabled}")
 
 # String flag evaluation with context
-context = {"userId": "user123", "sessionId": "session456"}
+context = EvaluationContext(targeting_key="user123", attributes={"sessionId": "session456"})
 variant = client.get_string_value("my-variant-flag", "default", context)
 print(f"Variant: {variant}")
 
@@ -149,13 +149,13 @@ provider.shutdown()
 ### Running tests
 
 ```bash
-pytest
+uv run test --frozen
 ```
 
 ### Type checking
 
 ```bash
-mypy src/
+uv run mypy-check
 ```
 
 ## License

providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/events.py

@@ -4,6 +4,7 @@
 
 from UnleashClient.events import BaseEvent, UnleashFetchedEvent, UnleashReadyEvent
 from openfeature.event import ProviderEvent
+from openfeature.provider import Metadata
 
 
 class UnleashProvider(Protocol):
@@ -14,7 +15,7 @@ def _event_handlers(self) -> dict[ProviderEvent, List[Callable]]:
         """Event handlers dictionary."""
         ...
 
-    def get_metadata(self) -> Any:
+    def get_metadata(self) -> Metadata:
         """Get provider metadata."""
         ...
 

providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py

@@ -2,6 +2,7 @@
 
 from typing import Any, Callable, Optional, Protocol
 
+from UnleashClient import UnleashClient
 from openfeature.evaluation_context import EvaluationContext
 from openfeature.exception import (
     FlagNotFoundError,
@@ -17,7 +18,7 @@ class UnleashProvider(Protocol):
     """Protocol defining the interface needed by FlagEvaluator."""
 
     @property
-    def client(self) -> Optional[Any]: ...
+    def client(self) -> Optional[UnleashClient]: ...
 
     @property
     def app_name(self) -> str: ...
@@ -196,11 +197,7 @@ def _resolve_variant_flag(
                     value = value_converter(payload_value)
                     return FlagResolutionDetails(
                         value=value,
-                        reason=(
-                            Reason.TARGETING_MATCH
-                            if value != default_value
-                            else Reason.DEFAULT
-                        ),
+                        reason=Reason.TARGETING_MATCH,
                         variant=variant.get("name"),
                         error_code=None,
                         error_message=None,

providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/tracking.py

@@ -3,6 +3,7 @@
 from typing import Any, Optional, Protocol
 import uuid
 
+from UnleashClient import UnleashClient
 from UnleashClient.events import UnleashEvent, UnleashEventType
 from openfeature.evaluation_context import EvaluationContext
 
@@ -11,7 +12,7 @@ class UnleashProvider(Protocol):
     """Protocol defining the interface needed by Tracker."""
 
     @property
-    def client(self) -> Optional[Any]: ...
+    def client(self) -> Optional[UnleashClient]: ...
 
     def _build_unleash_context(
         self, evaluation_context: Optional[EvaluationContext] = None

providers/openfeature-provider-unleash/tests/test_flag_evaluation.py

@@ -441,7 +441,7 @@ def test_variant_flag_scenarios():
         }
         result = provider.resolve_string_details("test_flag", "default")
         assert result.value == "default"
-        assert result.reason == Reason.DEFAULT
+        assert result.reason == Reason.TARGETING_MATCH
         assert result.variant == "test-variant"
 
         provider.shutdown()