fix: pr feedback

Signed-off-by: Konvalinka <[email protected]>

Author: leakonvalinka

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py

@@ -6,6 +6,7 @@
 
 import grpc
 from google.protobuf.json_format import MessageToDict
+from grpc import StatusCode
 
 from openfeature.evaluation_context import EvaluationContext
 from openfeature.event import ProviderEventDetails
@@ -209,20 +210,22 @@ def _create_request_args(self) -> dict:
 
         return request_args
 
-    def _fetch_metadata(self) -> typing.Optional[sync_pb2.GetMetadataResponse]:
+    def _fetch_metadata(self) -> dict:
         if self.config.sync_metadata_disabled:
-            return None
+            return {}
 
         context_values_request = sync_pb2.GetMetadataRequest()
-        context_values_response: sync_pb2.GetMetadataResponse
         try:
             context_values_response = self.stub.GetMetadata(
                 context_values_request, wait_for_ready=True
             )
-            return context_values_response
+            return MessageToDict(context_values_response)["metadata"]
         except grpc.RpcError as e:
-            logger.debug(f"Error getting sync metadata: {e}")
-            return None
+            if e.code() == StatusCode.UNIMPLEMENTED:
+                logger.debug("Metadata endpoint disabled")
+                return {}
+            else:
+                raise e
 
     def listen(self) -> None:
         call_args = (
@@ -234,7 +237,7 @@ def listen(self) -> None:
 
         while self.active:
             try:
-                context_values_response = self._fetch_metadata()
+                context_values = self._fetch_metadata()
 
                 request = sync_pb2.SyncFlagsRequest(**request_args)
 
@@ -248,13 +251,8 @@ def listen(self) -> None:
                     )
                     self.flag_store.update(json.loads(flag_str))
 
-                    context_values = {}
                     if flag_rsp.sync_context:
                         context_values = MessageToDict(flag_rsp.sync_context)
-                    elif context_values_response:
-                        context_values = MessageToDict(context_values_response)[
-                            "metadata"
-                        ]
 
                     if not self.connected:
                         self.emit_provider_ready(