Skip to content

Commit f7565fd

Browse files
committed
fix lints
Signed-off-by: gruebel <[email protected]>
1 parent b6ed7c8 commit f7565fd

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/flags.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,8 @@ def from_dict(cls, key: str, data: dict) -> "Flag":
7272
data["default_variant"] = data["defaultVariant"]
7373
del data["defaultVariant"]
7474

75-
if "source" in data:
76-
del data["source"]
77-
if "selector" in data:
78-
del data["selector"]
75+
data.pop("source", None)
76+
data.pop("selector", None)
7977
try:
8078
flag = cls(key=key, **data)
8179
return flag

providers/openfeature-provider-flagd/tests/e2e/step/event_steps.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
from openfeature.client import OpenFeatureClient
99
from openfeature.event import ProviderEvent
1010

11+
logger = logging.getLogger("openfeature.contrib.tests")
12+
1113
events = {
1214
"ready": ProviderEvent.PROVIDER_READY,
1315
"error": ProviderEvent.PROVIDER_ERROR,
@@ -28,7 +30,7 @@ def event_handles() -> list:
2830
)
2931
def add_event_handler(client: OpenFeatureClient, event_type: str, event_handles: list):
3032
def handler(event):
31-
logging.warning((event_type, event))
33+
logger.warning((event_type, event))
3234
event_handles.append(
3335
{
3436
"type": event_type,
@@ -38,7 +40,7 @@ def handler(event):
3840

3941
client.add_handler(events[event_type], handler)
4042

41-
logging.warning(("handler added", event_type))
43+
logger.warning(("handler added", event_type))
4244

4345

4446
def assert_handlers(handles, event_type: str, max_wait: int = 2):

providers/openfeature-provider-flagd/tests/e2e/step/provider_steps.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222

2323
MERGED_FILE = "merged_file"
2424

25+
logger = logging.getLogger("openfeature.contrib.tests")
26+
2527

2628
class TestProviderType(Enum):
2729
UNAVAILABLE = "unavailable"
@@ -133,7 +135,7 @@ def fin():
133135
try:
134136
container.stop()
135137
except: # noqa: E722 - we want to ensure all containers are stopped, even if we do have an exception here
136-
logging.debug("container was not running anymore")
138+
logger.debug("container was not running anymore")
137139

138140
# Teardown code
139141
request.addfinalizer(fin)

providers/openfeature-provider-flagd/tests/e2e/testfilter.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import logging
22
import os
33

4+
logger = logging.getLogger("openfeature.contrib.tests")
5+
46

57
class TestFilter:
68
def __init__(self, config, feature_list=None, resolver=None, base_path=None):
@@ -40,7 +42,7 @@ def filter_items(self, items):
4042
all_tags = self._get_item_tags(item)
4143

4244
# Debug: Print collected tags for each item
43-
logging.debug(f"Item: {item.nodeid}, Tags: {all_tags}")
45+
logger.debug(f"Item: {item.nodeid}, Tags: {all_tags}")
4446

4547
# Include-only logic: Skip items that do not match include_tags
4648
if (

0 commit comments

Comments
 (0)