Skip to content

fix(flagd): fix parameter name inconsistency with SDK version 0.8.1 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix(flagd): fix parameter name inconsistency with SDK version 0.8.1 #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,52 +158,52 @@ def get_metadata(self) -> Metadata:

def resolve_boolean_details(
self,
key: str,
flag_key: str,
default_value: bool,
evaluation_context: typing.Optional[EvaluationContext] = None,
) -> FlagResolutionDetails[bool]:
return self.resolver.resolve_boolean_details(
key, default_value, evaluation_context
flag_key, default_value, evaluation_context
)

def resolve_string_details(
self,
key: str,
flag_key: str,
default_value: str,
evaluation_context: typing.Optional[EvaluationContext] = None,
) -> FlagResolutionDetails[str]:
return self.resolver.resolve_string_details(
key, default_value, evaluation_context
flag_key, default_value, evaluation_context
)

def resolve_float_details(
self,
key: str,
flag_key: str,
default_value: float,
evaluation_context: typing.Optional[EvaluationContext] = None,
) -> FlagResolutionDetails[float]:
return self.resolver.resolve_float_details(
key, default_value, evaluation_context
flag_key, default_value, evaluation_context
)

def resolve_integer_details(
self,
key: str,
flag_key: str,
default_value: int,
evaluation_context: typing.Optional[EvaluationContext] = None,
) -> FlagResolutionDetails[int]:
return self.resolver.resolve_integer_details(
key, default_value, evaluation_context
flag_key, default_value, evaluation_context
)

def resolve_object_details(
self,
key: str,
flag_key: str,
default_value: typing.Union[dict, list],
evaluation_context: typing.Optional[EvaluationContext] = None,
) -> FlagResolutionDetails[typing.Union[dict, list]]:
return self.resolver.resolve_object_details(
key, default_value, evaluation_context
flag_key, default_value, evaluation_context
)

def emit_provider_ready_with_context(
Expand Down