Skip to content

Conversation

@leakonvalinka
Copy link
Member

@leakonvalinka leakonvalinka commented Jul 31, 2025

This PR

  • updates the sdk to fix mypy issues

Related Issues

Fixes: #288

Notes

Follow-up Tasks

How to test

Signed-off-by: Konvalinka <[email protected]>
Signed-off-by: Konvalinka <[email protected]>
Signed-off-by: Konvalinka <[email protected]>
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.26%. Comparing base (d89b5b8) to head (e57d658).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   94.20%   94.26%   +0.05%     
==========================================
  Files          20       20              
  Lines        1035     1028       -7     
==========================================
- Hits          975      969       -6     
+ Misses         60       59       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leakonvalinka leakonvalinka marked this pull request as ready for review July 31, 2025 13:15
@leakonvalinka leakonvalinka requested review from a team as code owners July 31, 2025 13:15
@aepfli aepfli merged commit f2028f5 into open-feature:main Jul 31, 2025
27 checks passed
@aepfli
Copy link
Member

aepfli commented Jul 31, 2025

although ignoring the typing information on purpose might not be the best idea, i merged this. We should move on, and fix the typing, if needed at a later stage (python knowledge not good enough on my side). But maybe @gruebel you can suggest us, what would be the best approach here.

@gruebel
Copy link
Member

gruebel commented Jul 31, 2025

No worries, most of the changes look good. If in doubt ignore the typing errors for now and check later. By later, I mean I will check 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] openfeature-sdk 0.8.2 has breaking changes

4 participants