Skip to content

Commit 6740235

Browse files
leohoareleohoare
committed
pass linting, ignore overrides mypy and callable line
1 parent 17acf42 commit 6740235

File tree

5 files changed

+29
-36
lines changed

5 files changed

+29
-36
lines changed

‎openfeature/client.py‎

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ async def get_boolean_value(
473473
default_value: bool,
474474
evaluation_context: typing.Optional[EvaluationContext] = None,
475475
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
476-
) -> typing.Coroutine[typing.Any, typing.Any, bool]:
476+
) -> bool:
477477
details = await self.get_boolean_details(
478478
flag_key,
479479
default_value,
@@ -488,7 +488,7 @@ async def get_boolean_details(
488488
default_value: bool,
489489
evaluation_context: typing.Optional[EvaluationContext] = None,
490490
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
491-
) -> typing.Coroutine[typing.Any, typing.Any, FlagEvaluationDetails[bool]]:
491+
) -> FlagEvaluationDetails[bool]:
492492
return await self.evaluate_flag_details(
493493
FlagType.BOOLEAN,
494494
flag_key,
@@ -503,7 +503,7 @@ async def get_string_value(
503503
default_value: str,
504504
evaluation_context: typing.Optional[EvaluationContext] = None,
505505
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
506-
) -> typing.Coroutine[typing.Any, typing.Any, str]:
506+
) -> str:
507507
details = await self.get_string_details(
508508
flag_key,
509509
default_value,
@@ -518,7 +518,7 @@ async def get_string_details(
518518
default_value: str,
519519
evaluation_context: typing.Optional[EvaluationContext] = None,
520520
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
521-
) -> typing.Coroutine[typing.Any, typing.Any, FlagEvaluationDetails[str]]:
521+
) -> FlagEvaluationDetails[str]:
522522
return await self.evaluate_flag_details(
523523
FlagType.STRING,
524524
flag_key,
@@ -533,7 +533,7 @@ async def get_integer_value(
533533
default_value: int,
534534
evaluation_context: typing.Optional[EvaluationContext] = None,
535535
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
536-
) -> typing.Coroutine[typing.Any, typing.Any, int]:
536+
) -> int:
537537
details = await self.get_integer_details(
538538
flag_key,
539539
default_value,
@@ -548,7 +548,7 @@ async def get_integer_details(
548548
default_value: int,
549549
evaluation_context: typing.Optional[EvaluationContext] = None,
550550
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
551-
) -> typing.Coroutine[typing.Any, typing.Any, FlagEvaluationDetails[int]]:
551+
) -> FlagEvaluationDetails[int]:
552552
return await self.evaluate_flag_details(
553553
FlagType.INTEGER,
554554
flag_key,
@@ -563,7 +563,7 @@ async def get_float_value(
563563
default_value: float,
564564
evaluation_context: typing.Optional[EvaluationContext] = None,
565565
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
566-
) -> typing.Coroutine[typing.Any, typing.Any, float]:
566+
) -> float:
567567
details = await self.get_float_details(
568568
flag_key,
569569
default_value,
@@ -578,7 +578,7 @@ async def get_float_details(
578578
default_value: float,
579579
evaluation_context: typing.Optional[EvaluationContext] = None,
580580
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
581-
) -> typing.Coroutine[typing.Any, typing.Any, FlagEvaluationDetails[float]]:
581+
) -> FlagEvaluationDetails[float]:
582582
return await self.evaluate_flag_details(
583583
FlagType.FLOAT,
584584
flag_key,
@@ -593,7 +593,7 @@ async def get_object_value(
593593
default_value: typing.Union[dict, list],
594594
evaluation_context: typing.Optional[EvaluationContext] = None,
595595
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
596-
) -> typing.Coroutine[typing.Any, typing.Any, typing.Union[dict, list]]:
596+
) -> typing.Union[dict, list]:
597597
details = await self.get_object_details(
598598
flag_key,
599599
default_value,
@@ -608,9 +608,7 @@ async def get_object_details(
608608
default_value: typing.Union[dict, list],
609609
evaluation_context: typing.Optional[EvaluationContext] = None,
610610
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
611-
) -> typing.Coroutine[
612-
typing.Any, typing.Any, FlagEvaluationDetails[typing.Union[dict, list]]
613-
]:
611+
) -> FlagEvaluationDetails[typing.Union[dict, list]]:
614612
return await self.evaluate_flag_details(
615613
FlagType.OBJECT,
616614
flag_key,
@@ -626,7 +624,7 @@ async def evaluate_flag_details( # noqa: PLR0915
626624
default_value: typing.Any,
627625
evaluation_context: typing.Optional[EvaluationContext] = None,
628626
flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
629-
) -> typing.Coroutine[typing.Any, typing.Any, FlagEvaluationDetails[typing.Any]]:
627+
) -> FlagEvaluationDetails[typing.Any]:
630628
"""
631629
Evaluate the flag requested by the user from the clients provider.
632630
@@ -772,7 +770,7 @@ async def _create_provider_evaluation(
772770
flag_key: str,
773771
default_value: typing.Any,
774772
evaluation_context: typing.Optional[EvaluationContext] = None,
775-
) -> typing.Coroutine[typing.Any, typing.Any, FlagEvaluationDetails[typing.Any]]:
773+
) -> FlagEvaluationDetails[typing.Any]:
776774
"""
777775
Asynchronous encapsulated method to create a FlagEvaluationDetail from a specific provider.
778776
@@ -801,7 +799,7 @@ async def _create_provider_evaluation(
801799
if not get_details_callable:
802800
raise GeneralError(error_message="Unknown flag type")
803801

804-
resolution = await get_details_callable(*args)
802+
resolution = await get_details_callable(*args) # type: ignore[misc]
805803
resolution.raise_for_error()
806804

807805
# we need to check the get_args to be compatible with union types.

‎openfeature/provider/__init__.py‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ async def resolve_boolean_details(
173173
flag_key: str,
174174
default_value: bool,
175175
evaluation_context: typing.Optional[EvaluationContext] = None,
176-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[bool]]:
176+
) -> FlagResolutionDetails[bool]:
177177
raise NotImplementedError("Method not implemented")
178178

179179
@abstractmethod
@@ -182,7 +182,7 @@ async def resolve_string_details(
182182
flag_key: str,
183183
default_value: str,
184184
evaluation_context: typing.Optional[EvaluationContext] = None,
185-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[str]]:
185+
) -> FlagResolutionDetails[str]:
186186
raise NotImplementedError("Method not implemented")
187187

188188
@abstractmethod
@@ -191,7 +191,7 @@ async def resolve_integer_details(
191191
flag_key: str,
192192
default_value: int,
193193
evaluation_context: typing.Optional[EvaluationContext] = None,
194-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[int]]:
194+
) -> FlagResolutionDetails[int]:
195195
raise NotImplementedError("Method not implemented")
196196

197197
@abstractmethod
@@ -200,7 +200,7 @@ async def resolve_float_details(
200200
flag_key: str,
201201
default_value: float,
202202
evaluation_context: typing.Optional[EvaluationContext] = None,
203-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[float]]:
203+
) -> FlagResolutionDetails[float]:
204204
raise NotImplementedError("Method not implemented")
205205

206206
@abstractmethod
@@ -209,7 +209,5 @@ async def resolve_object_details(
209209
flag_key: str,
210210
default_value: typing.Union[dict, list],
211211
evaluation_context: typing.Optional[EvaluationContext] = None,
212-
) -> typing.Coroutine[
213-
typing.Any, typing.Any, FlagResolutionDetails[typing.Union[dict, list]]
214-
]:
212+
) -> FlagResolutionDetails[typing.Union[dict, list]]:
215213
raise NotImplementedError("Method not implemented")

‎openfeature/provider/in_memory_provider.py‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,39 +136,37 @@ async def resolve_boolean_details(
136136
flag_key: str,
137137
default_value: bool,
138138
evaluation_context: typing.Optional[EvaluationContext] = None,
139-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[bool]]:
139+
) -> FlagResolutionDetails[bool]:
140140
return self._resolve(flag_key, evaluation_context)
141141

142142
async def resolve_string_details(
143143
self,
144144
flag_key: str,
145145
default_value: str,
146146
evaluation_context: typing.Optional[EvaluationContext] = None,
147-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[str]]:
147+
) -> FlagResolutionDetails[str]:
148148
return self._resolve(flag_key, evaluation_context)
149149

150150
async def resolve_integer_details(
151151
self,
152152
flag_key: str,
153153
default_value: int,
154154
evaluation_context: typing.Optional[EvaluationContext] = None,
155-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[int]]:
155+
) -> FlagResolutionDetails[int]:
156156
return self._resolve(flag_key, evaluation_context)
157157

158158
async def resolve_float_details(
159159
self,
160160
flag_key: str,
161161
default_value: float,
162162
evaluation_context: typing.Optional[EvaluationContext] = None,
163-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[float]]:
163+
) -> FlagResolutionDetails[float]:
164164
return self._resolve(flag_key, evaluation_context)
165165

166166
async def resolve_object_details(
167167
self,
168168
flag_key: str,
169169
default_value: typing.Union[dict, list],
170170
evaluation_context: typing.Optional[EvaluationContext] = None,
171-
) -> typing.Coroutine[
172-
typing.Any, typing.Any, FlagResolutionDetails[typing.Union[dict, list]]
173-
]:
171+
) -> FlagResolutionDetails[typing.Union[dict, list]]:
174172
return self._resolve(flag_key, evaluation_context)

‎openfeature/provider/no_op_provider.py‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ async def resolve_boolean_details(
8686
flag_key: str,
8787
default_value: bool,
8888
evaluation_context: typing.Optional[EvaluationContext] = None,
89-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[bool]]:
89+
) -> FlagResolutionDetails[bool]:
9090
return FlagResolutionDetails(
9191
value=default_value,
9292
reason=Reason.DEFAULT,
@@ -98,7 +98,7 @@ async def resolve_string_details(
9898
flag_key: str,
9999
default_value: str,
100100
evaluation_context: typing.Optional[EvaluationContext] = None,
101-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[str]]:
101+
) -> FlagResolutionDetails[str]:
102102
return FlagResolutionDetails(
103103
value=default_value,
104104
reason=Reason.DEFAULT,
@@ -110,7 +110,7 @@ async def resolve_integer_details(
110110
flag_key: str,
111111
default_value: int,
112112
evaluation_context: typing.Optional[EvaluationContext] = None,
113-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[int]]:
113+
) -> FlagResolutionDetails[int]:
114114
return FlagResolutionDetails(
115115
value=default_value,
116116
reason=Reason.DEFAULT,
@@ -122,7 +122,7 @@ async def resolve_float_details(
122122
flag_key: str,
123123
default_value: float,
124124
evaluation_context: typing.Optional[EvaluationContext] = None,
125-
) -> typing.Coroutine[typing.Any, typing.Any, FlagResolutionDetails[float]]:
125+
) -> FlagResolutionDetails[float]:
126126
return FlagResolutionDetails(
127127
value=default_value,
128128
reason=Reason.DEFAULT,
@@ -134,9 +134,7 @@ async def resolve_object_details(
134134
flag_key: str,
135135
default_value: typing.Union[dict, list],
136136
evaluation_context: typing.Optional[EvaluationContext] = None,
137-
) -> typing.Coroutine[
138-
typing.Any, typing.Any, FlagResolutionDetails[typing.Union[dict, list]]
139-
]:
137+
) -> FlagResolutionDetails[typing.Union[dict, list]]:
140138
return FlagResolutionDetails(
141139
value=default_value,
142140
reason=Reason.DEFAULT,

‎pyproject.toml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ local_partial_types = true # will become the new default from version 2
7272
pretty = true
7373
strict = true
7474
disallow_any_generics = false
75+
disable_error_code = ["override"]
7576

7677
[tool.ruff]
7778
exclude = [

0 commit comments

Comments
 (0)