Skip to content

Commit c5ea1e6

Browse files
committed
fixup! Finally hooks do not get called when the provider is not ready #424
Signed-off-by: christian.lutnik <[email protected]>
1 parent cf8de88 commit c5ea1e6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/test_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ def test_should_shortcircuit_if_provider_is_not_ready(
221221
assert flag_details.reason == Reason.ERROR
222222
assert flag_details.error_code == ErrorCode.PROVIDER_NOT_READY
223223
spy_hook.error.assert_called_once()
224-
224+
spy_hook.finally_after.assert_called_once()
225225

226226
# Requirement 1.7.7
227227
def test_should_shortcircuit_if_provider_is_in_irrecoverable_error_state(
@@ -243,7 +243,7 @@ def test_should_shortcircuit_if_provider_is_in_irrecoverable_error_state(
243243
assert flag_details.reason == Reason.ERROR
244244
assert flag_details.error_code == ErrorCode.PROVIDER_FATAL
245245
spy_hook.error.assert_called_once()
246-
246+
spy_hook.finally_after.assert_called_once()
247247

248248
def test_should_run_error_hooks_if_provider_returns_resolution_with_error_code():
249249
# Given

0 commit comments

Comments
 (0)