feat: Add PROVIDER_FATAL error code to ProviderInitializationError

Per reviewer feedback, add OpenFeature error code support to the
ProviderInitializationError exception class:

- Add error_code attribute with PROVIDER_FATAL default per OpenFeature spec
- Support custom error codes via constructor parameter
- Update all tests to verify error_code is properly set
- Update documentation to show error_code usage in exception handling

Addresses PR feedback from @beeme1mr regarding OpenFeature specification
requirement for provider initialization error codes.

Signed-off-by: Leo Romanovsky <[email protected]>

Author: leoromanovsky

README.md

@@ -141,6 +141,7 @@ begin
   puts "Provider is ready!"
 rescue OpenFeature::SDK::ProviderInitializationError => e
   puts "Provider failed to initialize: #{e.message}"
+  puts "Error code: #{e.error_code}"
   puts "Original error: #{e.original_error}"
 end
 
@@ -162,8 +163,8 @@ end
 
 The `set_provider_and_wait` method:
 - Waits for the provider's `init` method to complete successfully
-- Raises `ProviderInitializationError` if initialization fails or times out
-- Provides access to the original error and provider instance for debugging
+- Raises `ProviderInitializationError` with `PROVIDER_FATAL` error code if initialization fails or times out
+- Provides access to the original error, provider instance, and error code for debugging
 - Uses the same thread-safe provider switching as `set_provider`
 
 In some situations, it may be beneficial to register multiple providers in the same application.

lib/open_feature/sdk/provider_initialization_error.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "provider/error_code"
+
 module OpenFeature
   module SDK
     # Exception raised when a provider fails to initialize during setProviderAndWait
@@ -13,13 +15,18 @@ class ProviderInitializationError < StandardError
       # @return [Exception] the original error that caused the initialization failure
       attr_reader :original_error
 
+      # @return [String] the OpenFeature error code
+      attr_reader :error_code
+
       # @param message [String] the error message
       # @param provider [Object] the provider that failed to initialize
       # @param original_error [Exception] the original error that caused the failure
-      def initialize(message, provider: nil, original_error: nil)
+      # @param error_code [String] the OpenFeature error code (defaults to PROVIDER_FATAL)
+      def initialize(message, provider: nil, original_error: nil, error_code: Provider::ErrorCode::PROVIDER_FATAL)
         super(message)
         @provider = provider
         @original_error = original_error
+        @error_code = error_code
       end
     end
   end

spec/open_feature/sdk/configuration_spec.rb

@@ -115,6 +115,7 @@
           expect(error.provider).to be(provider)
           expect(error.original_error).to be_a(StandardError)
           expect(error.original_error.message).to eq(error_message)
+          expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::PROVIDER_FATAL)
         end
       end
 
@@ -145,6 +146,7 @@
           expect(error.message).to include("Provider initialization timed out after 0.1 seconds")
           expect(error.provider).to be(provider)
           expect(error.original_error).to be_a(Timeout::Error)
+          expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::PROVIDER_FATAL)
         end
       end
 

spec/open_feature/sdk/provider_initialization_error_spec.rb

@@ -28,6 +28,10 @@
       it "inherits from StandardError" do
         expect(error).to be_a(StandardError)
       end
+
+      it "sets the error code to PROVIDER_FATAL by default" do
+        expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::PROVIDER_FATAL)
+      end
     end
 
     context "with minimal parameters" do
@@ -44,6 +48,10 @@
       it "has nil original_error" do
         expect(error.original_error).to be_nil
       end
+
+      it "sets the error code to PROVIDER_FATAL by default" do
+        expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::PROVIDER_FATAL)
+      end
     end
 
     context "with provider but no original_error" do
@@ -69,6 +77,16 @@
         expect(error.original_error).to be(original_error)
       end
     end
+
+    context "with custom error code" do
+      subject(:error) do
+        described_class.new(message, provider:, original_error:, error_code: "CUSTOM_ERROR")
+      end
+
+      it "sets the custom error code" do
+        expect(error.error_code).to eq("CUSTOM_ERROR")
+      end
+    end
   end
 
   describe "inheritance" do

spec/open_feature/sdk_spec.rb

@@ -44,7 +44,9 @@
 
       expect do
         OpenFeature::SDK.set_provider_and_wait(provider)
-      end.to raise_error(OpenFeature::SDK::ProviderInitializationError, /Provider initialization failed/)
+      end.to raise_error(OpenFeature::SDK::ProviderInitializationError, /Provider initialization failed/) do |error|
+        expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::PROVIDER_FATAL)
+      end
 
       # Clean up
       OpenFeature::SDK.set_provider(OpenFeature::SDK::Provider::NoOpProvider.new)