Skip to content

Commit 40f040e

Browse files
committed
Resolve provider tests when merging in event details work
Signed-off-by: jescriba <[email protected]>
1 parent 4aae450 commit 40f040e

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

Tests/OpenFeatureTests/DeveloperExperienceTests.swift

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,12 +192,12 @@ final class DeveloperExperienceTests: XCTestCase {
192192
let mockEvent2Subject = CurrentValueSubject<ProviderEvent?, Never>(nil)
193193
// Create test providers that can emit events
194194
let eventEmittingProvider1 = MockProvider(
195-
initialize: { _ in mockEvent1Subject.send(.ready) },
195+
initialize: { _ in mockEvent1Subject.send(.ready(nil)) },
196196
getBooleanEvaluation: { _, _, _ in throw OpenFeatureError.generalError(message: "test error") },
197197
observe: { mockEvent1Subject.eraseToAnyPublisher() }
198198
)
199199
let eventEmittingProvider2 = MockProvider(
200-
initialize: { _ in mockEvent2Subject.send(.ready) },
200+
initialize: { _ in mockEvent2Subject.send(.ready(nil)) },
201201
getBooleanEvaluation: { _, _, _ in throw OpenFeatureError.generalError(message: "test error") },
202202
observe: { mockEvent2Subject.eraseToAnyPublisher() }
203203
)
@@ -230,18 +230,18 @@ final class DeveloperExperienceTests: XCTestCase {
230230
await OpenFeatureAPI.shared.setProviderAndWait(provider: multiProvider)
231231

232232
// Emit events from the first provider
233-
mockEvent1Subject.send(.ready)
234-
mockEvent1Subject.send(.configurationChanged)
233+
mockEvent1Subject.send(.ready(nil))
234+
mockEvent1Subject.send(.configurationChanged(nil))
235235

236236
// Emit events from the second provider
237-
mockEvent2Subject.send(.error(errorCode: .general, message: "Test error"))
237+
mockEvent2Subject.send(.error(ProviderEventDetails(message: "Test error", errorCode: .general)))
238238
// Wait for all events to be received
239239
await fulfillment(of: [readyExpectation, configChangedExpectation, errorExpectation], timeout: 2)
240240

241241
// Verify that events from both providers were received
242-
XCTAssertTrue(receivedEvents.contains(.ready))
243-
XCTAssertTrue(receivedEvents.contains(.configurationChanged))
244-
XCTAssertTrue(receivedEvents.contains(.error(errorCode: .general, message: "Test error")))
242+
XCTAssertTrue(receivedEvents.contains(.ready(nil)))
243+
XCTAssertTrue(receivedEvents.contains(.configurationChanged(nil)))
244+
XCTAssertTrue(receivedEvents.contains(.error(ProviderEventDetails(message: "Test error", errorCode: .general))))
245245
XCTAssertGreaterThanOrEqual(receivedEvents.count, 3)
246246

247247
observer.cancel()

Tests/OpenFeatureTests/MultiProviderTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,12 @@ final class MultiProviderTests: XCTestCase {
227227
}
228228

229229
func testObserveWithMultipleProviders() {
230-
let mockEvent1 = ProviderEvent.ready
230+
let mockEvent1 = ProviderEvent.ready(nil)
231231
let mockProvider1 = MockProvider(
232232
getBooleanEvaluation: { _, _, _ in throw OpenFeatureError.generalError(message: "test error") },
233233
observe: { Just(mockEvent1).eraseToAnyPublisher() }
234234
)
235-
let mockEvent2 = ProviderEvent.contextChanged
235+
let mockEvent2 = ProviderEvent.contextChanged(nil)
236236
let mockProvider2 = MockProvider(
237237
getBooleanEvaluation: { _, _, _ in throw OpenFeatureError.generalError(message: "test error") },
238238
observe: { Just(mockEvent2).eraseToAnyPublisher() }

0 commit comments

Comments
 (0)