Skip to content

Commit 3440220

Browse files
Merge pull request #280 from open-formulieren/chore/279-bump-to-rc
Create release candidate
2 parents 21d6c92 + 4def439 commit 3440220

File tree

8 files changed

+181
-7
lines changed

8 files changed

+181
-7
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
.storybook/ @sergei-maertens
2+
src/ @sergei-maertens
3+
LICENSE.md @joeribekker

CHANGELOG.md

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,29 @@
11
# Changes
22

3+
## 1.0.0-rc.0 (2025-12-23)
4+
5+
First release candidate for the stable 1.0.0 release.
6+
7+
**API changes**
8+
9+
- [`#138`][#138] Internal components now use explicit `isReadOnly` semantics rather than
10+
`isDisabled`. This should vastly improve the experience for screen reader users.
11+
12+
**Bugfixes**
13+
14+
- [`#263`][#263] Fixed char count being displayed if no text was entered yet.
15+
- [`#274`][#274] Fixed the date and datepicker fields triggering validation too soon on blur.
16+
17+
**Project maintenance**
18+
19+
- Updated the documentation (storybook) landing page.
20+
- Added contributing guidelines.
21+
- Defined codeowners in Github (initial pass).
22+
23+
[#263]: https://github.comm/open-formulieren/formio-renderer/issues/263
24+
[#138]: https://github.comm/open-formulieren/formio-renderer/issues/138
25+
[#274]: https://github.comm/open-formulieren/formio-renderer/issues/274
26+
327
## 1.0.0-beta.4 (2025-12-22)
428

529
Fifth beta version for the stable 1.0.0 release.
@@ -11,7 +35,6 @@ Fifth beta version for the stable 1.0.0 release.
1135
- [`#270`][#270] Fixed option descriptions not being displayed in `radio` components.
1236
- [`#267`][#267] Fixed modals opening scrolling the page to the top.
1337

14-
[#265]: https://github.com/open-formulieren/formio-renderer/issues/265
1538
[#268]: https://github.com/open-formulieren/formio-renderer/issues/268
1639
[#270]: https://github.com/open-formulieren/formio-renderer/issues/270
1740
[#267]: https://github.com/open-formulieren/formio-renderer/issues/267

CODE_OF_CONDUCT.md

Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
# Code of Conduct
2+
3+
## Our Pledge
4+
5+
In the interest of fostering an open and welcoming environment, we as contributors and maintainers
6+
pledge to make participation in our project and our community a harassment-free experience for
7+
everyone, regardless of age, body size, disability, ethnicity, sex characteristics, gender identity
8+
and expression, level of experience, education, socio-economic status, nationality, personal
9+
appearance, race, religion, or sexual identity and orientation.
10+
11+
## Our Standards
12+
13+
Examples of behavior that contributes to creating a positive environment include:
14+
15+
- Using welcoming and inclusive language
16+
- Being respectful of differing viewpoints and experiences
17+
- Gracefully accepting constructive criticism
18+
- Focusing on what is best for the community
19+
- Showing empathy towards other community members
20+
21+
Examples of unacceptable behavior by participants include:
22+
23+
- The use of sexualized language or imagery and unwelcome sexual attention or advances
24+
- Trolling, insulting/derogatory comments, and personal or political attacks
25+
- Public or private harassment
26+
- Publishing others' private information, such as a physical or electronic address, without explicit
27+
permission
28+
- Other conduct which could reasonably be considered inappropriate in a professional setting
29+
30+
## Our Responsibilities
31+
32+
Project maintainers are responsible for clarifying the standards of acceptable behavior and are
33+
expected to take appropriate and fair corrective action in response to any instances of unacceptable
34+
behavior.
35+
36+
Project maintainers have the right and responsibility to remove, edit, or reject comments, commits,
37+
code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or
38+
to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate,
39+
threatening, offensive, or harmful.
40+
41+
## Scope
42+
43+
This Code of Conduct applies within all project spaces, and it also applies when an individual is
44+
representing the project or its community in public spaces. Examples of representing a project or
45+
community include using an official project e-mail address, posting via an official social media
46+
account, or acting as an appointed representative at an online or offline event. Representation of a
47+
project may be further defined and clarified by project maintainers.
48+
49+
## Enforcement
50+
51+
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting
52+
the project team at `helpdesk@maykinmedia.nl`. All complaints will be reviewed and investigated and
53+
will result in a response that is deemed necessary and appropriate to the circumstances. The project
54+
team is obligated to maintain confidentiality with regard to the reporter of an incident. Further
55+
details of specific enforcement policies may be posted separately.
56+
57+
Project maintainers who do not follow or enforce the Code of Conduct in good faith may face
58+
temporary or permanent repercussions as determined by other members of the project's leadership.
59+
60+
## Attribution
61+
62+
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at
63+
https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
64+
65+
[homepage]: https://www.contributor-covenant.org

CONTRIBUTING.md

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
# Contribution guidelines
2+
3+
We are grateful for anyone spending their valuable time on contributions to this library.
4+
5+
To avoid dissapointments, before contributing code, please review our
6+
[Design goals](https://open-formulieren.github.io/formio-renderer/). We cannot commit to maintaining
7+
features that are not directly beneficial to
8+
[Open Forms](https://open-forms.readthedocs.io/en/stable/).
9+
10+
However, if you wish to contribute despite these warnings, you can do so in a number of ways!
11+
12+
## Reporting bugs
13+
14+
If you have encountered a bug in this project, please check if an issue already exists in the list
15+
of existing [issues][issues]. If such an issue does not exist, you can create a [new
16+
issue][new_issue]. When writing the bug report, try to add a clear example that shows how to
17+
reproduce said bug.
18+
19+
[issues]: https://github.com/open-formulieren/formio-renderer/issues
20+
[new_issue]: https://github.com/open-formulieren/formio-renderer/issues/new/choose
21+
22+
## Performing accessibility audits and testing
23+
24+
Accessibility is definitely a blind spot for us - if you can help out with user tests or by
25+
performing accessibility audits, we will happily receive the results and check what can be done to
26+
resolve issues!
27+
28+
## Adding new features
29+
30+
We recommend creating a feature request ticket **BEFORE** developing a new feature. This way, we can
31+
gauge interest in the feature and let you know if we're not (yet) open to it so that you don't spend
32+
a lot of time on something that will not be merged in the near future.
33+
34+
If you get the go-ahead and start writing code, that's wonderful! We do ask you to keep the quality
35+
control process in mind - and all of the things below are enforced through Github Actions:
36+
37+
- we use Typescript for its type-safety features - downcasting is frowned upon (i.e. you should
38+
really avoid using `as SomeType`!).
39+
- code formatting is done with prettier, you can run `npm run checkformat` and `npm run format`, or
40+
enable format-on-save in your editor.
41+
- code is linted using eslint, you can run it locally using `npm run lint`.
42+
- code must have tests - often these will be interaction tests in Storybook, but for unit-test like
43+
tests you can write additional tests and run them with vitest.
44+
- components must be documented in Storybook, so that they undergo visual regression testing.
45+
- use [NL Design System](https://www.nldesignsystem.nl/) components rather than reinventing the
46+
wheel.
47+
48+
In general - check the `scripts` section in `package.json` for the available developer tools!
49+
50+
### Commit messages
51+
52+
Commit messages are very important to us, as they are essential to understand _why_ changes are
53+
made. They should explain your thought process.
54+
55+
- always refer to the github issue in the commit message summary.
56+
- stick to commit message best practices by using a short summary, and add additional paragraphs to
57+
the body when relevant
58+
- good things to note down are: alternative solutions considered and reason why they were rejected,
59+
the requirements that applied at the time, possible limitations/external factors that were
60+
relevant...

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
[![Storybook](https://img.shields.io/badge/docs-Storybook-FF4785?style=flat)][Storybook]
55
[![Coverage](https://codecov.io/github/open-formulieren/formio-renderer/graph/badge.svg?token=446OCQXNUG)](https://codecov.io/github/open-formulieren/formio-renderer)
66
![Code formatting with Prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)
7+
[![TypeScript](https://img.shields.io/badge/TypeScript-3178C6?logo=typescript&logoColor=fff)](#)
8+
[![Vite](https://img.shields.io/badge/Vite-646CFF?logo=vite&logoColor=fff)](#)
79

810
The "renderer" is the React render engine used in Open Forms, responsible for displaying the form
911
fields for the user to fill out and capturing the input data.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-formulieren/formio-renderer",
3-
"version": "1.0.0-beta.4",
3+
"version": "1.0.0-rc.0",
44
"description": "Alternative Form.io renderer made for Open Forms.",
55
"type": "module",
66
"exports": {

src/0001-index.mdx

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,15 @@ import {Meta} from '@storybook/addon-docs/blocks';
66

77
`@open-formulieren/formio-renderer` is a pure React based renderer for Formio form definitions.
88

9+
[![NPM](https://img.shields.io/npm/v/@open-formulieren/formio-renderer.svg)](https://www.npmjs.com/package/@open-formulieren/formio-renderer)
10+
[![TypeScript](https://img.shields.io/badge/TypeScript-3178C6?logo=typescript&logoColor=fff)](#)
11+
[![Vite](https://img.shields.io/badge/Vite-646CFF?logo=vite&logoColor=fff)](#)
12+
913
## Quickstart
1014

11-
**NOTE** - this library is still in active development and public API _may_ change.
15+
As of version 1.0, the public API is stable, and Semantic Versioning applies. The
16+
[changelog](https://github.com/open-formulieren/formio-renderer/blob/main/CHANGELOG.md) is on
17+
Github.
1218

1319
**High level API**
1420

@@ -121,7 +127,13 @@ Forms.
121127

122128
## Roadmap
123129

124-
See [Github](https://github.com/open-formulieren/open-forms/issues/5133)
130+
The port from Formio.js to our own implementation is complete, which was the scope for 1.0.
131+
132+
We now want to realize improvements that were not possible before, in particular:
133+
134+
- improve the `editgrid` component
135+
- improve the `addressNL` component
136+
- re-evaluate past deprecations and check if simplifications are possible
125137

126138
## Design goals
127139

@@ -165,9 +177,18 @@ The code base is structured so that:
165177
- we build on top of `@open-formulieren/types` so that we only worry about the features that Open
166178
Forms provides/supports.
167179

180+
## Developer mantras
181+
182+
- Your code must be readable for other developers. Double check with them to make sure.
183+
- Avoid pulling in unnecessary dependencies - check if native HTML features exist. If large
184+
dependencies are necessary, see if you can lazy-load them.
185+
- Similar code is not the same - sometimes repeating/duplicating code is the better approach.
186+
- Keep final bundle size in mind - use lazy-loading to facilate bundle splitting.
187+
- Dare to say "no" when something does not fit our design goals or design decisions.
188+
168189
## Design decisions
169190

170-
Decisions made while ipmlementing the renderer.
191+
Decisions made while implementing the renderer.
171192

172193
**Backend API interaction**
173194

0 commit comments

Comments
 (0)