feat(jike-client): cache user instance

Author: sxzz

package.json

@@ -56,6 +56,7 @@
     "@types/md5": "^2.3.2",
     "@types/node": "*",
     "@types/sharp": "^0.30.2",
+    "@vitest/ui": "^0.10.0",
     "bumpp": "^7.1.1",
     "dayjs": "^1.11.1",
     "esbuild": "^0.14.38",

pnpm-lock.yaml

@@ -23,10 +23,13 @@ interface EventMap {
 
 export type { JikeClientJSON }
 
+const userSelfKey = Symbol('userSelfKey')
+
 export class JikeClient extends EventEmitter<EventMap> {
   #refreshToken: string
   #config: ApiConfigResolved
   #client!: Api
+  #userCache: { [userSelfKey]?: JikeUser<true> } & Record<string, JikeUser> = {}
 
   get accessToken() {
     return this.#config.accessToken
@@ -164,15 +167,17 @@ export class JikeClient extends EventEmitter<EventMap> {
    * @returns {@link JikeUser} 实例
    */
   getUser<M extends boolean = boolean>(username: string): JikeUser {
-    return new JikeUser<M>(this, username)
+    if (this.#userCache[username]) return this.#userCache[username]
+    return (this.#userCache[username] = new JikeUser<M>(this, username))
   }
 
   /**
    * 获取自身用户
    * @returns {@link JikeUser} 实例
    */
-  getSelf() {
-    return new JikeUser<true>(this, undefined)
+  getSelf(): JikeUser<true> {
+    if (this.#userCache[userSelfKey]) return this.#userCache[userSelfKey]!
+    return (this.#userCache[userSelfKey] = new JikeUser<true>(this, undefined))
   }
 
   /**

src/client/client.ts

@@ -52,4 +52,10 @@ describe('constructor', () => {
     const { beforeRetry, ...clien2Config } = client2.config
     expect(clien2Config).toEqual(clienConfig)
   })
+
+  it('should create user instance only once', () => {
+    expect(client.getSelf()).toBe(client.getSelf())
+    const username = '82D23B32-CF36-4C59-AD6F-D05E3552CBF3'
+    expect(client.getUser(username)).toBe(client.getUser(username))
+  })
 })