Skip to content

Commit 55c4ceb

Browse files
chore(ui): Revamp test suite details page (#25139)
* chore(ui): Revamp test suite details page * address gitar-bot comments * replace antd with MUI components * Update openmetadata-ui/src/main/resources/ui/src/pages/TestSuiteDetailsPage/TestSuiteDetailsPage.component.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix conflicts * address gitar-bot comments * fix failing e2e tests * fix failing e2e test * fix failing test * minor fix * minor fix --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 09018b5 commit 55c4ceb

File tree

5 files changed

+251
-176
lines changed

5 files changed

+251
-176
lines changed

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/TestSuitePipelineRedeploy.spec.ts

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,6 @@ test.describe('Bulk Re-Deploy pipelines ', PLAYWRIGHT_INGESTION_TAG_OBJ, () => {
3838
await afterAction();
3939
});
4040

41-
test.afterAll('Clean up', async ({ browser }) => {
42-
const { afterAction, apiContext } = await createNewPage(browser);
43-
44-
await table1.delete(apiContext);
45-
await table2.delete(apiContext);
46-
47-
await afterAction();
48-
});
49-
5041
test.beforeEach('Visit home page', async ({ page }) => {
5142
await redirectToHomePage(page);
5243
});
@@ -69,13 +60,18 @@ test.describe('Bulk Re-Deploy pipelines ', PLAYWRIGHT_INGESTION_TAG_OBJ, () => {
6960

7061
await expect(page.getByRole('button', { name: 'Re Deploy' })).toBeEnabled();
7162

72-
const redeployResponse = page.waitForResponse('/api/v1/services/ingestionPipelines/deploy/*');
63+
const redeployResponse = page.waitForResponse(
64+
(response) =>
65+
response.url().includes('/api/v1/services/ingestionPipelines/deploy') &&
66+
response.request().method() === 'POST' &&
67+
response.status() === 200
68+
);
7369
await page.getByRole('button', { name: 'Re Deploy' }).click();
7470
await redeployResponse;
7571

76-
await expect(
77-
page.getByText('Pipelines Re Deploy Successfully')
78-
).toBeVisible();
72+
await expect(page.getByTestId('alert-bar')).toHaveText(
73+
/Pipelines Re Deploy Successfully/i
74+
);
7975
});
8076

8177
// TODO: Add test to verify the re-deployed pipelines for Database, Dashboard and other entities

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/TestSuite.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ test('Logical TestSuite', PLAYWRIGHT_INGESTION_TAG_OBJ, async ({ page, ownerPage
107107
await test.step('Domain Add, Update and Remove', async () => {
108108
await assignSingleSelectDomain(page, domain1.responseData);
109109
await assignSingleSelectDomain(page, domain2.responseData);
110-
await removeSingleSelectDomain(page, domain2.responseData, false);
110+
await removeSingleSelectDomain(page, domain2.responseData, true);
111111
});
112112

113113
await test.step(

openmetadata-ui/src/main/resources/ui/src/components/Settings/Services/Ingestion/IngestionPipelineList/IngestionPipelineList.component.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ import { Button, Col, Row, TablePaginationConfig } from 'antd';
1414
import { ColumnsType, TableProps } from 'antd/lib/table';
1515
import { FilterValue, TableRowSelection } from 'antd/lib/table/interface';
1616
import { AxiosError } from 'axios';
17-
import { isNil, map, startCase } from 'lodash';
17+
import capitalize from 'lodash/capitalize';
18+
import isNil from 'lodash/isNil';
19+
import map from 'lodash/map';
20+
import startCase from 'lodash/startCase';
1821
import { useCallback, useEffect, useMemo, useState } from 'react';
1922
import { useTranslation } from 'react-i18next';
2023
import { useAirflowStatus } from '../../../../../context/AirflowStatusProvider/AirflowStatusProvider';
@@ -110,8 +113,8 @@ export const IngestionPipelineList = ({
110113
await Promise.all(promises);
111114

112115
showSuccessToast(
113-
`${t('label.pipeline-plural')} ${t('label.re-deploy')} ${t(
114-
'label.successfully-lowercase'
116+
`${t('label.pipeline-plural')} ${t('label.re-deploy')} ${capitalize(
117+
t('label.successfully-lowercase')
115118
)}`
116119
);
117120
} catch (error) {

0 commit comments

Comments
 (0)