fix: ensure updateWorkflowStats runs even if final drainAndFlush throws

manerow · manerow · commit 5a50dc95d987 · 2026-02-19T08:53:04.000+01:00
diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/insights/workflows/dataAssets/DataAssetsWorkflow.java b/openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/insights/workflows/dataAssets/DataAssetsWorkflow.java
@@ -322,8 +322,11 @@ record EntityFuture(EntityInterface entity, Future<Void> future) {}
       this.executor = null;
     }
 
-    drainAndFlush(operationsQueue, contextData);
-    updateWorkflowStats(source.getName(), source.getStats());
+    try {
+      drainAndFlush(operationsQueue, contextData);
+    } finally {
+      updateWorkflowStats(source.getName(), source.getStats());
+    }
   }
 
   @SuppressWarnings("unchecked")

Original file line number	Diff line number	Diff line change
`@@ -322,8 +322,11 @@ record EntityFuture(EntityInterface entity, Future<Void> future) {}`
`322`	`322`	`this.executor = null;`
`323`	`323`	`}`
`324`	`324`
`325`		`- drainAndFlush(operationsQueue, contextData);`
`326`		`- updateWorkflowStats(source.getName(), source.getStats());`
	`325`	`+ try {`
	`326`	`+ drainAndFlush(operationsQueue, contextData);`
	`327`	`+ } finally {`
	`328`	`+ updateWorkflowStats(source.getName(), source.getStats());`
	`329`	`+ }`
`327`	`330`	`}`
`328`	`331`
`329`	`332`	`@SuppressWarnings("unchecked")`