Skip to content

Commit 9bf9786

Browse files
committed
address gitar
1 parent b65ff22 commit 9bf9786

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

openmetadata-ui/src/main/resources/ui/src/components/Container/ContainerDataModel/ContainerDataModel.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,9 @@ const ContainerDataModel: FC<ContainerDataModelProps> = ({
8585
useState<Column>();
8686
const [expandedRowKeys, setExpandedRowKeys] = useState<string[]>([]);
8787

88-
const schema = pruneEmptyChildren(dataModel?.columns ?? []);
88+
const schema = useMemo(() => pruneEmptyChildren(dataModel?.columns ?? []), [
89+
dataModel?.columns,
90+
]);
8991

9092
// Sync displayed columns with GenericProvider for ColumnDetailPanel navigation
9193
useEffect(() => {

openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/ColumnDetailPanel.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ export const ColumnDetailPanel = <T extends ColumnOrTask = Column>({
203203
}
204204

205205
return undefined;
206-
}, [localToast.open]);
206+
}, [localToast]);
207207

208208
const [activeColumn, setActiveColumn] = useState<T | null>(column);
209209

openmetadata-ui/src/main/resources/ui/src/components/DriveService/Worksheet/WorksheetColumnsTable/WorksheetColumnsTable.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,9 @@ function WorksheetColumnsTable() {
9292
};
9393
}, [permissions, worksheetDetails]);
9494

95-
const schema = pruneEmptyChildren(worksheetDetails?.columns ?? []);
95+
const schema = useMemo(() => pruneEmptyChildren(worksheetDetails?.columns ?? []), [
96+
worksheetDetails?.columns,
97+
]);
9698

9799
// Sync displayed columns with GenericProvider for ColumnDetailPanel navigation
98100
useEffect(() => {

0 commit comments

Comments
 (0)