fix tests

Author: pmbrull

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/searchIndex/ElasticSearchBulkSink.java

@@ -434,11 +434,11 @@ public void updateConcurrentRequests(int concurrentRequests) {
    * Checks if vector embeddings are enabled for a specific entity type.
    * This combines SearchRepository capability check with job configuration.
    */
-  private boolean isVectorEmbeddingEnabledForEntity(String entityType) {
+  boolean isVectorEmbeddingEnabledForEntity(String entityType) {
     return false;
   }
 
-  private void addEntitiesToVectorIndexBatch(
+  void addEntitiesToVectorIndexBatch(
       CustomBulkProcessor bulkProcessor, List<EntityInterface> entities, boolean recreateIndex) {
     // TODO: Implement Elasticsearch vector embedding support
   }

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/searchIndex/OpenSearchBulkSink.java

@@ -489,13 +489,13 @@ public void updateConcurrentRequests(int concurrentRequests) {
     LOG.info("Concurrent requests updated to: {}", concurrentRequests);
   }
 
-  private boolean isVectorEmbeddingEnabledForEntity(String entityType) {
+  boolean isVectorEmbeddingEnabledForEntity(String entityType) {
     return searchRepository.isVectorEmbeddingEnabled()
         && OpenSearchVectorService.getInstance() != null
         && AvailableEntityTypes.isVectorIndexable(entityType);
   }
 
-  private void addEntitiesToVectorIndexBatch(
+  void addEntitiesToVectorIndexBatch(
       CustomBulkProcessor bulkProcessor,
       List<EntityInterface> entities,
       boolean recreateIndex,

openmetadata-service/src/test/java/org/openmetadata/service/apps/bundles/searchIndex/ElasticSearchBulkSinkSimpleTest.java

@@ -5,6 +5,7 @@
 import static org.mockito.Mockito.lenient;
 
 import es.co.elastic.clients.elasticsearch.ElasticsearchClient;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 import org.junit.jupiter.api.BeforeEach;
@@ -83,21 +84,13 @@ void testContextDataHandling() {
 
   @Test
   void testIsVectorEmbeddingEnabledForEntity() {
-    // Test default implementation returns false
-    boolean result = elasticSearchBulkSink.isVectorEmbeddingEnabledForEntity("table");
-    assertEquals(false, result);
-
-    result = elasticSearchBulkSink.isVectorEmbeddingEnabledForEntity("user");
-    assertEquals(false, result);
-
-    result = elasticSearchBulkSink.isVectorEmbeddingEnabledForEntity("dashboard");
-    assertEquals(false, result);
+    assertEquals(false, elasticSearchBulkSink.isVectorEmbeddingEnabledForEntity("table"));
+    assertEquals(false, elasticSearchBulkSink.isVectorEmbeddingEnabledForEntity("user"));
+    assertEquals(false, elasticSearchBulkSink.isVectorEmbeddingEnabledForEntity("dashboard"));
   }
 
   @Test
-  void testAddEntityToVectorIndex() {
-    // Test default implementation does nothing (no exception thrown)
-    // This should not throw any exception as the default implementation is empty
-    elasticSearchBulkSink.addEntityToVectorIndex(null, null, true);
+  void testAddEntitiesToVectorIndexBatch() {
+    elasticSearchBulkSink.addEntitiesToVectorIndexBatch(null, Collections.emptyList(), true);
   }
 }

openmetadata-service/src/test/java/org/openmetadata/service/apps/bundles/searchIndex/OpenSearchBulkSinkSimpleTest.java

@@ -4,6 +4,7 @@
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.mockito.Mockito.lenient;
 
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 import org.junit.jupiter.api.BeforeEach;
@@ -83,21 +84,13 @@ void testContextDataHandling() {
 
   @Test
   void testIsVectorEmbeddingEnabledForEntity() {
-    // Test default implementation returns false
-    boolean result = openSearchBulkSink.isVectorEmbeddingEnabledForEntity("table");
-    assertEquals(false, result);
-
-    result = openSearchBulkSink.isVectorEmbeddingEnabledForEntity("user");
-    assertEquals(false, result);
-
-    result = openSearchBulkSink.isVectorEmbeddingEnabledForEntity("dashboard");
-    assertEquals(false, result);
+    assertEquals(false, openSearchBulkSink.isVectorEmbeddingEnabledForEntity("table"));
+    assertEquals(false, openSearchBulkSink.isVectorEmbeddingEnabledForEntity("user"));
+    assertEquals(false, openSearchBulkSink.isVectorEmbeddingEnabledForEntity("dashboard"));
   }
 
   @Test
-  void testAddEntityToVectorIndex() {
-    // Test default implementation does nothing (no exception thrown)
-    // This should not throw any exception as the default implementation is empty
-    openSearchBulkSink.addEntityToVectorIndex(null, null, true, null);
+  void testAddEntitiesToVectorIndexBatch() {
+    openSearchBulkSink.addEntitiesToVectorIndexBatch(null, Collections.emptyList(), true, null);
   }
 }