Commit f6da290
Fix backend search and remove dead code
Critical fixes from code review:
- Add missing @QueryParam("q") String query parameter to LearningResourceResource.list()
- Pass query parameter to filter so backend search actually works
- Remove dead code: pageCondition() and categoryCondition() methods (replaced by pageIdsCondition and categoriesCondition)
Backend search was previously broken - the frontend sent 'q' parameter but backend never declared or used it, silently ignoring all search requests.
Co-authored-by: Copilot <Copilot@users.noreply.github.com>1 parent babf6c1 commit f6da290
File tree
2 files changed
+18
-34
lines changed- openmetadata-service/src/main/java/org/openmetadata/service
- jdbi3
- resources/learning
2 files changed
+18
-34
lines changedLines changed: 0 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | 291 | | |
304 | 292 | | |
305 | 293 | | |
| |||
313 | 301 | | |
314 | 302 | | |
315 | 303 | | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | 304 | | |
329 | 305 | | |
330 | 306 | | |
| |||
Lines changed: 18 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | 131 | | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
142 | 147 | | |
143 | 148 | | |
144 | 149 | | |
| |||
166 | 171 | | |
167 | 172 | | |
168 | 173 | | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
169 | 177 | | |
170 | 178 | | |
171 | 179 | | |
| |||
0 commit comments