Skip to content

Commit 38e3933

Browse files
committed
core: minor comments
Signed-off-by: Brice Goglin <[email protected]>
1 parent 7612891 commit 38e3933

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

hwloc/topology-x86.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1381,6 +1381,9 @@ int hwloc_look_x86(struct hwloc_backend *backend, unsigned long flags)
13811381
/* check if binding works */
13821382
memset(&hooks, 0, sizeof(hooks));
13831383
support.membind = &memsupport;
1384+
/* We could just copy the main hooks (except in some corner cases),
1385+
* but the current overhead is negligible, so just always reget them.
1386+
*/
13841387
hwloc_set_native_binding_hooks(&hooks, &support);
13851388
if (hooks.get_thisthread_cpubind && hooks.set_thisthread_cpubind) {
13861389
get_cpubind = hooks.get_thisthread_cpubind;

hwloc/topology.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1921,6 +1921,7 @@ hwloc_topology_insert_group_object(struct hwloc_topology *topology, hwloc_obj_t
19211921
if (hwloc_bitmap_isset(nodeset, numa->os_index))
19221922
hwloc_bitmap_or(obj->cpuset, obj->cpuset, numa->cpuset);
19231923
}
1924+
/* FIXME insert by nodeset to group NUMAs even if CPUless? */
19241925

19251926
cmp = hwloc_obj_cmp_sets(obj, root);
19261927
if (cmp == HWLOC_OBJ_INCLUDED) {

0 commit comments

Comments
 (0)