Skip to content

Commit 5577481

Browse files
committed
xml/import: cleanup unused/non-unused function parameters
Signed-off-by: Brice Goglin <[email protected]>
1 parent 9b3b4dd commit 5577481

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

hwloc/topology-xml.c

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ hwloc_xml_callbacks_reset(void)
104104

105105
static void
106106
hwloc__xml_import_object_attr(struct hwloc_topology *topology,
107-
struct hwloc_xml_backend_data_s *data __hwloc_attribute_unused,
108107
struct hwloc_obj *obj,
109108
const char *name, const char *value,
110109
hwloc__xml_import_state_t state,
@@ -435,8 +434,7 @@ hwloc___xml_import_info(char **infonamep, char **infovaluep,
435434
}
436435

437436
static int
438-
hwloc__xml_import_obj_info(struct hwloc_xml_backend_data_s *data __hwloc_attribute_unused,
439-
hwloc_obj_t obj,
437+
hwloc__xml_import_obj_info(hwloc_obj_t obj,
440438
hwloc__xml_import_state_t state)
441439
{
442440
char *infoname = NULL;
@@ -457,7 +455,7 @@ hwloc__xml_import_obj_info(struct hwloc_xml_backend_data_s *data __hwloc_attribu
457455
}
458456

459457
static int
460-
hwloc__xml_import_pagetype(hwloc_topology_t topology __hwloc_attribute_unused, struct hwloc_numanode_attr_s *memory,
458+
hwloc__xml_import_pagetype(struct hwloc_numanode_attr_s *memory,
461459
hwloc__xml_import_state_t state)
462460
{
463461
uint64_t size = 0, count = 0;
@@ -496,7 +494,8 @@ hwloc__xml_import_pagetype(hwloc_topology_t topology __hwloc_attribute_unused, s
496494
}
497495

498496
static int
499-
hwloc__xml_import_userdata(hwloc_topology_t topology __hwloc_attribute_unused, hwloc_obj_t obj,
497+
hwloc__xml_import_userdata(hwloc_topology_t topology,
498+
hwloc_obj_t obj,
500499
hwloc__xml_import_state_t state)
501500
{
502501
size_t length = 0;
@@ -619,7 +618,7 @@ static void hwloc__xml_import_report_outoforder(hwloc_topology_t topology, hwloc
619618

620619
static int
621620
hwloc__xml_import_object(hwloc_topology_t topology,
622-
struct hwloc_xml_backend_data_s *data __hwloc_attribute_unused,
621+
struct hwloc_xml_backend_data_s *data,
623622
hwloc_obj_t parent, hwloc_obj_t obj, int *gotignored,
624623
hwloc__xml_import_state_t state)
625624
{
@@ -668,7 +667,7 @@ hwloc__xml_import_object(hwloc_topology_t topology,
668667
state->global->msgprefix, attrname);
669668
goto error_with_object;
670669
}
671-
hwloc__xml_import_object_attr(topology, data, obj, attrname, attrvalue, state, &ignored);
670+
hwloc__xml_import_object_attr(topology, obj, attrname, attrvalue, state, &ignored);
672671
}
673672
}
674673

@@ -689,9 +688,9 @@ hwloc__xml_import_object(hwloc_topology_t topology,
689688

690689
} else if (!strcmp(tag, "page_type")) {
691690
if (obj->type == HWLOC_OBJ_NUMANODE) {
692-
ret = hwloc__xml_import_pagetype(topology, &obj->attr->numanode, &childstate);
691+
ret = hwloc__xml_import_pagetype(&obj->attr->numanode, &childstate);
693692
} else if (!parent) {
694-
ret = hwloc__xml_import_pagetype(topology, &topology->machine_memory, &childstate);
693+
ret = hwloc__xml_import_pagetype(&topology->machine_memory, &childstate);
695694
} else {
696695
if (hwloc__xml_verbose())
697696
fprintf(stderr, "%s: invalid non-NUMAnode object child %s\n",
@@ -700,7 +699,7 @@ hwloc__xml_import_object(hwloc_topology_t topology,
700699
}
701700

702701
} else if (!strcmp(tag, "info")) {
703-
ret = hwloc__xml_import_obj_info(data, obj, &childstate);
702+
ret = hwloc__xml_import_obj_info(obj, &childstate);
704703
} else if (!strcmp(tag, "userdata")) {
705704
ret = hwloc__xml_import_userdata(topology, obj, &childstate);
706705
} else {

0 commit comments

Comments
 (0)