Skip to content

Commit 57ed73a

Browse files
committed
hwloc/shmem.h: add/improve doc about return values
Refs #578 Signed-off-by: Brice Goglin <[email protected]>
1 parent 212aa47 commit 57ed73a

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

include/hwloc/shmem.h

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright © 2013-2018 Inria. All rights reserved.
2+
* Copyright © 2013-2023 Inria. All rights reserved.
33
* See COPYING in top-level directory.
44
*/
55

@@ -48,6 +48,8 @@ extern "C" {
4848
* This length (in bytes) must be used in hwloc_shmem_topology_write()
4949
* and hwloc_shmem_topology_adopt() later.
5050
*
51+
* \return the length, or -1 on error, for instance if flags are invalid.
52+
*
5153
* \note Flags \p flags are currently unused, must be 0.
5254
*/
5355
HWLOC_DECLSPEC int hwloc_shmem_topology_get_length(hwloc_topology_t topology,
@@ -74,9 +76,10 @@ HWLOC_DECLSPEC int hwloc_shmem_topology_get_length(hwloc_topology_t topology,
7476
* is not. However the caller may also allocate it manually in shared memory
7577
* to share it as well.
7678
*
77-
* \return -1 with errno set to EBUSY if the virtual memory mapping defined
79+
* \return 0 on success.
80+
* \return -1 with errno set to \c EBUSY if the virtual memory mapping defined
7881
* by \p mmap_address and \p length isn't available in the process.
79-
* \return -1 with errno set to EINVAL if \p fileoffset, \p mmap_address
82+
* \return -1 with errno set to \c EINVAL if \p fileoffset, \p mmap_address
8083
* or \p length aren't page-aligned.
8184
*/
8285
HWLOC_DECLSPEC int hwloc_shmem_topology_write(hwloc_topology_t topology,
@@ -112,14 +115,16 @@ HWLOC_DECLSPEC int hwloc_shmem_topology_write(hwloc_topology_t topology,
112115
*
113116
* \note This function takes care of calling hwloc_topology_abi_check().
114117
*
115-
* \return -1 with errno set to EBUSY if the virtual memory mapping defined
118+
* \return 0 on success.
119+
*
120+
* \return -1 with errno set to \c EBUSY if the virtual memory mapping defined
116121
* by \p mmap_address and \p length isn't available in the process.
117122
*
118-
* \return -1 with errno set to EINVAL if \p fileoffset, \p mmap_address
123+
* \return -1 with errno set to \c EINVAL if \p fileoffset, \p mmap_address
119124
* or \p length aren't page-aligned, or do not match what was given to
120125
* hwloc_shmem_topology_write() earlier.
121126
*
122-
* \return -1 with errno set to EINVAL if the layout of the topology structure
127+
* \return -1 with errno set to \c EINVAL if the layout of the topology structure
123128
* is different between the writer process and the adopter process.
124129
*/
125130
HWLOC_DECLSPEC int hwloc_shmem_topology_adopt(hwloc_topology_t *topologyp,

0 commit comments

Comments
 (0)