freebsd: fix a node array leak when distances are available but ignored

bgoglin · bgoglin · commit 8d0c50abf4ff · 2024-07-05T10:56:37.000+02:00
Forgotten when adding NO_DISTANCES flag in commit c90ad95 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
diff --git a/hwloc/topology-freebsd.c b/hwloc/topology-freebsd.c
@@ -509,6 +509,8 @@ hwloc_look_freebsd_domains(struct hwloc_topology *topology){
     }
     if(nodes != NULL && !(topology->flags & HWLOC_TOPOLOGY_FLAG_NO_DISTANCES))
       set_locality_info(topology, ndomains, nodes);
+    else
+      free(nodes);
 
   /* nodes is either freed or given to the core in set_locality_info() */
   free(domains_memory);

Original file line number	Diff line number	Diff line change
`@@ -509,6 +509,8 @@ hwloc_look_freebsd_domains(struct hwloc_topology *topology){`
`509`	`509`	`}`
`510`	`510`	`if(nodes != NULL && !(topology->flags & HWLOC_TOPOLOGY_FLAG_NO_DISTANCES))`
`511`	`511`	`set_locality_info(topology, ndomains, nodes);`
	`512`	`+ else`
	`513`	`+ free(nodes);`
`512`	`514`
`513`	`515`	`/* nodes is either freed or given to the core in set_locality_info() */`
`514`	`516`	`free(domains_memory);`