core/insert_group: free the group if merging with root

bgoglin · bgoglin · commit 90b508f2a2c7 · 2023-09-18T11:57:47.000+02:00
Don't leak that object in this special case.

Signed-off-by: Brice Goglin &lt;Brice.Goglin@inria.fr&gt;
diff --git a/hwloc/topology.c b/hwloc/topology.c
@@ -2105,6 +2105,7 @@ hwloc_topology_insert_group_object(struct hwloc_topology *topology, hwloc_obj_t
     res = hwloc__insert_object_by_cpuset(topology, NULL, obj, NULL /* do not show errors on stdout */);
   } else {
     /* just merge root */
+    hwloc_free_unlinked_object(obj);
     res = root;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -2105,6 +2105,7 @@ hwloc_topology_insert_group_object(struct hwloc_topology *topology, hwloc_obj_t`
`2105`	`2105`	`res = hwloc__insert_object_by_cpuset(topology, NULL, obj, NULL /* do not show errors on stdout */);`
`2106`	`2106`	`} else {`
`2107`	`2107`	`/* just merge root */`
	`2108`	`+ hwloc_free_unlinked_object(obj);`
`2108`	`2109`	`res = root;`
`2109`	`2110`	`}`
`2110`	`2111`