Skip to content

Commit ecc13f1

Browse files
committed
Makefile: don't have contrib/windows in both DIST_SUBDIRS and EXTRA_DIST
We used EXTRA_DIST of the entire directory to avoid listing all MSVC files, and DIST_SUBDIRS for checking the version numbers in the windows config files. Only use DIST_SUBDIRS (and list all files explicitly). Signed-off-by: Brice Goglin <[email protected]>
1 parent 8249f30 commit ecc13f1

File tree

2 files changed

+35
-9
lines changed

2 files changed

+35
-9
lines changed

Makefile.am

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,6 @@ if HWLOC_BUILD_STANDALONE
5959
dist_pkgdata_DATA = contrib/hwloc-valgrind.supp
6060
endif
6161

62-
# Only install entire visual studio subdirectory if we're building in
63-
# standalone mode
64-
if HWLOC_BUILD_STANDALONE
65-
EXTRA_DIST += contrib/windows
66-
endif
67-
6862
if HWLOC_BUILD_STANDALONE
6963
dist-hook:
7064
sh "$(top_srcdir)/config/distscript.sh" "$(top_srcdir)" "$(distdir)" "$(HWLOC_VERSION)"

contrib/windows/Makefile.am

Lines changed: 35 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,39 @@
1-
# Copyright © 2009-2018 Inria. All rights reserved.
1+
# Copyright © 2009-2020 Inria. All rights reserved.
22
# See COPYING in top-level directory.
33

4-
# This Makefile doesn't run by default because it requires
5-
# bash, and grep built with support for -P
4+
# This Makefile isn't used outside of make dist by default
5+
# because test-windows-version.sh requires
6+
# bash, and grep built with support for -P
67

78
TESTS = test-windows-version.sh
9+
10+
EXTRA_DIST = \
11+
README \
12+
hwloc.sln \
13+
hwloc_config.h \
14+
private_config.h \
15+
static-components.h \
16+
libhwloc.vcxproj \
17+
libhwloc.vcxproj.filters \
18+
hwloc-annotate.vcxproj \
19+
hwloc-annotate.vcxproj.filters \
20+
hwloc-bind.vcxproj \
21+
hwloc-bind.vcxproj.filters \
22+
hwloc-calc.vcxproj \
23+
hwloc-calc.vcxproj.filters \
24+
hwloc-diff.vcxproj \
25+
hwloc-diff.vcxproj.filters \
26+
hwloc-distrib.vcxproj \
27+
hwloc-distrib.vcxproj.filters \
28+
hwloc-gather-cpuid.vcxproj \
29+
hwloc-gather-cpuid.vcxproj.filters \
30+
hwloc-info.vcxproj \
31+
hwloc-info.vcxproj.filters \
32+
hwloc-patch.vcxproj \
33+
hwloc-patch.vcxproj.filters \
34+
lstopo-no-graphics.vcxproj \
35+
lstopo-no-graphics.vcxproj.filters \
36+
lstopo-win.vcxproj \
37+
lstopo-win.vcxproj.filters \
38+
lstopo.vcxproj \
39+
lstopo.vcxproj.filters

0 commit comments

Comments
 (0)