Skip to content

Commit f71fb7e

Browse files
bgoglinndenoyelle
authored andcommitted
doxy+rename: clarify capital name renaming
They are renamed to PREFIX_hwloc_FOO instead of PREFIX_HWLOC_FOO We could fix it but it doesn't matter much (people aren't supposed to use those renamed names anyway) and it could break existing hacks (if anybody actually depends on such renamed name). Thanks to Samuel K. Gutierrez for the report. Signed-off-by: Brice Goglin <[email protected]>
1 parent 72330c0 commit f71fb7e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

doc/hwloc.doxy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2788,7 +2788,7 @@ HWLOC_SETUP_CORE <em>must</em> be invoked if using the m4 macros):
27882788
hwloc's types and public symbols with "foo_"; meaning that function
27892789
hwloc_init() becomes foo_hwloc_init(). Enum values are prefixed
27902790
with an upper-case translation if the prefix supplied;
2791-
HWLOC_OBJ_CORE becomes FOO_HWLOC_OBJ_CORE. This is recommended
2791+
HWLOC_OBJ_CORE becomes FOO_hwloc_OBJ_CORE. This is recommended
27922792
behavior if you are including hwloc in middleware -- it is possible
27932793
that your software will be combined with other software that links
27942794
to another copy of hwloc. If both uses of hwloc utilize different

include/hwloc/rename.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ extern "C" {
2828
#define HWLOC_MUNGE_NAME(a, b) HWLOC_MUNGE_NAME2(a, b)
2929
#define HWLOC_MUNGE_NAME2(a, b) a ## b
3030
#define HWLOC_NAME(name) HWLOC_MUNGE_NAME(HWLOC_SYM_PREFIX, hwloc_ ## name)
31+
/* FIXME: should be "HWLOC_ ## name" below, unchanged because it doesn't matter much and could break some embedders hacks */
3132
#define HWLOC_NAME_CAPS(name) HWLOC_MUNGE_NAME(HWLOC_SYM_PREFIX_CAPS, hwloc_ ## name)
3233

3334
/* Now define all the "real" names to be the prefixed names. This

0 commit comments

Comments
 (0)