Fix datatype cleanup

cniethammer · cniethammer · commit 582b57be72f8 · 2021-02-15T21:48:16.000+01:00
The type of MPI_Datatype is not specified in the standard. They must not
be implemented as objects and can, e.g., also be implemented via integers.
Therefore, removing the incorrect comparison against NULL here.

Signed-off-by: Christoph Niethammer &lt;niethammer@hlrs.de&gt;
diff --git a/tst_types.c b/tst_types.c
@@ -500,7 +500,7 @@ int tst_type_cleanup (void)
   int i;
   for (i=PREDEFINED_DATATYPES; i < TST_TYPES_NUM; i++)
     {
-      if (NULL == ((void*)types[i].mpi_datatype) || MPI_DATATYPE_NULL == types[i].mpi_datatype)
+      if (MPI_DATATYPE_NULL == types[i].mpi_datatype)
         continue;
 
       MPI_Type_free (&types[i].mpi_datatype);

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,7 @@ int tst_type_cleanup (void)`
`500`	`500`	`int i;`
`501`	`501`	`for (i=PREDEFINED_DATATYPES; i < TST_TYPES_NUM; i++)`
`502`	`502`	`{`
`503`		`- if (NULL == ((void*)types[i].mpi_datatype) \|\| MPI_DATATYPE_NULL == types[i].mpi_datatype)`
	`503`	`+ if (MPI_DATATYPE_NULL == types[i].mpi_datatype)`
`504`	`504`	`continue;`
`505`	`505`
`506`	`506`	`MPI_Type_free (&types[i].mpi_datatype);`