Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Commit 4f6b1f6

Browse files
authored
Merge pull request #1299 from kawashima-fj/pr/v2.x/fortran-named-constants
v2.x: fortran: Correct named constants and a datatype name
2 parents 3132bd5 + a470677 commit 4f6b1f6

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

ompi/datatype/ompi_datatype_module.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ ompi_predefined_datatype_t ompi_mpi_integer8 = OMPI_DATATYPE_INIT_UNAVAILA
258258
#if OMPI_HAVE_FORTRAN_INTEGER16
259259
ompi_predefined_datatype_t ompi_mpi_integer16 = OMPI_DATATYPE_INIT_PREDEFINED_BASIC_TYPE_FORTRAN (INT, INTEGER16, OMPI_SIZEOF_FORTRAN_INTEGER16, OMPI_ALIGNMENT_FORTRAN_INTEGER16, OMPI_DATATYPE_FLAG_DATA_INT);
260260
#else
261-
ompi_predefined_datatype_t ompi_mpi_integer16 = OMPI_DATATYPE_INIT_UNAVAILABLE (INTEGER8, OMPI_DATATYPE_FLAG_DATA_FORTRAN | OMPI_DATATYPE_FLAG_DATA_INT);
261+
ompi_predefined_datatype_t ompi_mpi_integer16 = OMPI_DATATYPE_INIT_UNAVAILABLE (INTEGER16, OMPI_DATATYPE_FLAG_DATA_FORTRAN | OMPI_DATATYPE_FLAG_DATA_INT);
262262
#endif
263263

264264
/*
@@ -536,7 +536,7 @@ int32_t ompi_datatype_init( void )
536536
}
537537

538538
/*
539-
* This MUST match the order of ompi/include/mpif-common.h
539+
* This MUST match the order of ompi/include/mpif-values.pl
540540
* Any change will break binary compatibility of Fortran programs.
541541
*/
542542
MOOG(datatype_null, 0);
@@ -625,6 +625,9 @@ int32_t ompi_datatype_init( void )
625625
/* MPI 3.0 types */
626626
MOOG(count, 72);
627627

628+
/* MPI 2.2 types (again) */
629+
MOOG(c_bool, 73);
630+
628631
/**
629632
* Now make sure all non-contiguous types are marked as such.
630633
*/

ompi/include/mpi.h.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,6 +1163,7 @@ OMPI_DECLSPEC extern MPI_Fint *MPI_F_STATUSES_IGNORE;
11631163
#define MPI_C_LONG_DOUBLE_COMPLEX OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_c_long_double_complex)
11641164
#endif
11651165
#define MPI_CXX_BOOL OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_cxx_bool)
1166+
#define MPI_CXX_COMPLEX OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_cxx_cplex)
11661167
#define MPI_CXX_FLOAT_COMPLEX OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_cxx_cplex)
11671168
#define MPI_CXX_DOUBLE_COMPLEX OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_cxx_dblcplex)
11681169
#define MPI_CXX_LONG_DOUBLE_COMPLEX OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_cxx_ldblcplex)

ompi/include/mpif-values.pl

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
# Copyright (c) 2011-2014 Cisco Systems, Inc. All rights reserved.
44
# Copyright (c) 2016 Research Organization for Information Science
55
# and Technology (RIST). All rights reserved.
6+
# Copyright (c) 2016 FUJITSU LIMITED. All rights reserved.
67
# $COPYRIGHT$
78
#
89
# Additional copyrights may follow
@@ -105,6 +106,7 @@ sub write_file {
105106
$handles->{MPI_MAXLOC} = 11;
106107
$handles->{MPI_MINLOC} = 12;
107108
$handles->{MPI_REPLACE} = 13;
109+
$handles->{MPI_NO_OP} = 14;
108110

109111
$handles->{MPI_COMM_NULL} = 2;
110112
$handles->{MPI_DATATYPE_NULL} = 0;
@@ -160,20 +162,22 @@ sub write_file {
160162
$handles->{MPI_LONG} = 41;
161163
$handles->{MPI_UNSIGNED_LONG} = 42;
162164
$handles->{MPI_LONG_LONG_INT} = 43;
165+
$handles->{MPI_LONG_LONG} = $handles->{MPI_LONG_LONG_INT};
163166
$handles->{MPI_UNSIGNED_LONG_LONG} = 44;
164167
$handles->{MPI_FLOAT} = 45;
165168
$handles->{MPI_DOUBLE} = 46;
166169
$handles->{MPI_LONG_DOUBLE} = 47;
167170
$handles->{MPI_FLOAT_INT} = 48;
168171
$handles->{MPI_DOUBLE_INT} = 49;
169-
$handles->{MPI_LONGDBL_INT} = 50;
172+
$handles->{MPI_LONG_DOUBLE_INT} = 50;
170173
$handles->{MPI_LONG_INT} = 51;
171174
$handles->{MPI_2INT} = 52;
172175
$handles->{MPI_SHORT_INT} = 53;
173176
$handles->{MPI_CXX_BOOL} = 54;
174-
$handles->{MPI_CXX_CPLEX} = 55;
175-
$handles->{MPI_CXX_DBLCPLEX} = 56;
176-
$handles->{MPI_CXX_LDBLCPLEX} = 57;
177+
$handles->{MPI_CXX_FLOAT_COMPLEX} = 55;
178+
$handles->{MPI_CXX_COMPLEX} = $handles->{MPI_CXX_FLOAT_COMPLEX};
179+
$handles->{MPI_CXX_DOUBLE_COMPLEX} = 56;
180+
$handles->{MPI_CXX_LONG_DOUBLE_COMPLEX} = 57;
177181
$handles->{MPI_INT8_T} = 58;
178182
$handles->{MPI_UINT8_T} = 59;
179183
$handles->{MPI_INT16_T} = 60;
@@ -189,6 +193,7 @@ sub write_file {
189193
$handles->{MPI_C_DOUBLE_COMPLEX} = 70;
190194
$handles->{MPI_C_LONG_DOUBLE_COMPLEX} = 71;
191195
$handles->{MPI_COUNT} = 72;
196+
$handles->{MPI_C_BOOL} = 73;
192197

193198
$handles->{MPI_MESSAGE_NO_PROC} = 1;
194199

@@ -235,6 +240,8 @@ sub write_file {
235240
$constants->{MPI_WIN_FLAVOR_ALLOCATE} = 2;
236241
$constants->{MPI_WIN_FLAVOR_DYNAMIC} = 3;
237242
$constants->{MPI_WIN_FLAVOR_SHARED} = 4;
243+
$constants->{MPI_WIN_UNIFIED} = 0;
244+
$constants->{MPI_WIN_SEPARATE} = 1;
238245

239246
$constants->{MPI_BSEND_OVERHEAD} = 128;
240247
$constants->{MPI_ORDER_C} = 0;

0 commit comments

Comments
 (0)