Fix Java Coverity issue

nrgraham23 · nrgraham23 · commit a7bc948b29cb · 2016-06-23T17:09:00.000+02:00
Fixing a possible error that Coverity pointed out in
ompi_java_exceptionCheck.

Signed-off-by: Nathaniel Graham &lt;nrgraham23@gmail.com&gt;
diff --git a/ompi/mpi/java/c/mpi_MPI.c b/ompi/mpi/java/c/mpi_MPI.c
@@ -1157,9 +1157,8 @@ jboolean ompi_java_exceptionCheck(JNIEnv *env, int rc)
         (*env)->DeleteLocalRef(env, jmessage);
         return JNI_TRUE;
     }
-    else if (JNI_TRUE == jni_exception) {
-        return JNI_TRUE;
-    }
+    /* If we get here, a JNI error has occurred. */
+    return JNI_TRUE;
 }
 
 void* ompi_java_attrSet(JNIEnv *env, jbyteArray jval)

Original file line number	Diff line number	Diff line change
`@@ -1157,9 +1157,8 @@ jboolean ompi_java_exceptionCheck(JNIEnv *env, int rc)`
`1157`	`1157`	`(*env)->DeleteLocalRef(env, jmessage);`
`1158`	`1158`	`return JNI_TRUE;`
`1159`	`1159`	`}`
`1160`		`- else if (JNI_TRUE == jni_exception) {`
`1161`		`- return JNI_TRUE;`
`1162`		`- }`
	`1160`	`+ /* If we get here, a JNI error has occurred. */`
	`1161`	`+ return JNI_TRUE;`
`1163`	`1162`	`}`
`1164`	`1163`
`1165`	`1164`	`void* ompi_java_attrSet(JNIEnv *env, jbyteArray jval)`