ompi/op: Provide a default value for type/flags

jjhursey · jjhursey · commit ac9cd78cb682 · 2016-06-03T08:17:05.000-05:00
* User defined ops leave the op_type unset which can confuse logic in a collective component that is trying to convert the op to the approprate local function. (cherry picked from commit open-mpi/ompi@a776d78)
diff --git a/ompi/op/op.c b/ompi/op/op.c
@@ -443,6 +443,10 @@ static void ompi_op_construct(ompi_op_t *new_op)
 {
     int i;
 
+    /* Provide a default of a high value. Useful for non-predefined ops. */
+    new_op->op_type = OMPI_OP_NUM_OF_TYPES;
+    new_op->o_flags = 0;
+
     /* assign entry in fortran <-> c translation array */
 
     new_op->o_f_to_c_index =

Original file line number	Diff line number	Diff line change
`@@ -443,6 +443,10 @@ static void ompi_op_construct(ompi_op_t *new_op)`
`443`	`443`	`{`
`444`	`444`	`int i;`
`445`	`445`
	`446`	`+ /* Provide a default of a high value. Useful for non-predefined ops. */`
	`447`	`+ new_op->op_type = OMPI_OP_NUM_OF_TYPES;`
	`448`	`+ new_op->o_flags = 0;`
	`449`	`+`
`446`	`450`	`/* assign entry in fortran <-> c translation array */`
`447`	`451`
`448`	`452`	`new_op->o_f_to_c_index =`