Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Commit baf8fd1

Browse files
authored
Merge pull request #1340 from rhc54/cmr202/binding
Correct the binding algorithm to decouple it from oversubscribe.
2 parents 36d10ca + 20b9a2a commit baf8fd1

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

orte/mca/rmaps/base/rmaps_base_map_job.c

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -242,17 +242,14 @@ void orte_rmaps_base_map_job(int fd, short args, void *cbdata)
242242
* already (e.g., during the call to comm_spawn), then we don't
243243
* override it */
244244
if (!OPAL_BINDING_POLICY_IS_SET(jdata->map->binding)) {
245-
/* if the user specified that we allow oversubscription, then do not bind.
246-
* otherwise, if the user explicitly mapped-by some object, then we default
247-
* to binding to that object */
248-
if ((ORTE_MAPPING_SUBSCRIBE_GIVEN & ORTE_GET_MAPPING_DIRECTIVE(orte_rmaps_base.mapping)) &&
249-
!(ORTE_MAPPING_NO_OVERSUBSCRIBE & ORTE_GET_MAPPING_DIRECTIVE(orte_rmaps_base.mapping))) {
250-
OPAL_SET_BINDING_POLICY(jdata->map->binding, OPAL_BIND_TO_NONE);
251-
} else if (OPAL_BINDING_POLICY_IS_SET(opal_hwloc_binding_policy)) {
245+
if (OPAL_BINDING_POLICY_IS_SET(opal_hwloc_binding_policy)) {
252246
/* if the user specified a default binding policy via
253-
* MCA param, then we use it */
247+
* MCA param, then we use it - this can include a directive
248+
* to overload */
254249
jdata->map->binding = opal_hwloc_binding_policy;
255250
} else {
251+
/* if the user explicitly mapped-by some object, then we default
252+
* to binding to that object */
256253
orte_mapping_policy_t mpol;
257254
mpol = ORTE_GET_MAPPING_POLICY(orte_rmaps_base.mapping);
258255
if (ORTE_MAPPING_POLICY_IS_SET(jdata->map->mapping) &&

0 commit comments

Comments
 (0)