Skip to content

Commit 47e71f7

Browse files
committed
dist upload: fix conditional to choose autodetect
There was an error in the conditional to determine if the upload-release-to-s3 script needed to auto-detect any of the configuration options (project, branch, version, date). This commit fixes that logic so that the script works even when all four arguments aren't specified. tl;dr: "or", not "and" Signed-off-by: Brian Barrett <[email protected]>
1 parent ea46ef1 commit 47e71f7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

dist/upload-release-to-s3.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ def arg_check_copy(target, source, name):
9494
print('No files specified. Stopping.')
9595
exit(1)
9696

97-
if (args_dict['project'] == None and args_dict['branch'] == None
98-
and args_dict['version'] == None) and args_dict['date'] == None:
97+
if (args_dict['project'] == None or args_dict['branch'] == None
98+
or args_dict['version'] == None) or args_dict['date'] == None:
9999
if args_dict['yes']:
100100
print('Can not use --yes option unless --project, --branch, --version, ' +
101101
'and --date are also set.')

0 commit comments

Comments
 (0)