Skip to content

Commit 007ca2a

Browse files
author
rhc54
committed
Merge pull request #1442 from rhc54/topic/cleanup
Cleanup a debug statement. Plug a memory leak
2 parents 584b801 + af1444b commit 007ca2a

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

opal/mca/pmix/pmix120/pmix/src/server/pmix_server.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2298,6 +2298,11 @@ static pmix_status_t server_switchyard(pmix_peer_t *peer, uint32_t tag,
22982298
event_del(&peer->recv_event);
22992299
peer->recv_ev_active = false;
23002300
}
2301+
/* remove this peer from the nspace ranks */
2302+
pmix_list_remove_item(&peer->info->nptr->server->ranks, &peer->info->super);
2303+
PMIX_RELEASE(peer->info);
2304+
pmix_pointer_array_set_item(&pmix_server_globals.clients, peer->index, NULL);
2305+
PMIX_RELEASE(peer);
23012306
return rc;
23022307
}
23032308

opal/mca/pmix/pmix120/pmix/src/usock/usock_sendrecv.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,10 @@ static pmix_status_t send_bytes(int sd, char **buf, size_t *remain)
101101
goto exit;
102102
}
103103
/* we hit an error and cannot progress this message */
104-
pmix_output(0, "pmix_usock_msg_send_bytes: write failed: %s (%d) [sd = %d]",
105-
strerror(pmix_socket_errno),
106-
pmix_socket_errno, sd);
104+
pmix_output_verbose(10, pmix_globals.debug_output,
105+
"pmix_usock_msg_send_bytes: write failed: %s (%d) [sd = %d]",
106+
strerror(pmix_socket_errno),
107+
pmix_socket_errno, sd);
107108
ret = PMIX_ERR_COMM_FAILURE;
108109
goto exit;
109110
}
@@ -147,7 +148,7 @@ static int read_bytes(int sd, char **buf, size_t *remain)
147148
* the error back to the RML and let the caller know
148149
* to abort this message
149150
*/
150-
pmix_output_verbose(2, pmix_globals.debug_output,
151+
pmix_output_verbose(10, pmix_globals.debug_output,
151152
"pmix_usock_msg_recv: readv failed: %s (%d)",
152153
strerror(pmix_socket_errno),
153154
pmix_socket_errno);

0 commit comments

Comments
 (0)