Skip to content

Commit 0e25c95

Browse files
committed
common/ofi: Fix check for OFI in build files
The changes made in f5e1a67 have been done after the common/ofi component was removed and thus the component doesn't reflect the changes made their. Namely f5e1a67 changed: - How to call OPAL_CHECK_OFI (It sets opal_ofi_happy to yes now) - Dropped the common part in the build flags for ofi Signed-off-by: guserav <[email protected]>
1 parent 4ad78aa commit 0e25c95

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

opal/mca/common/ofi/Makefile.am

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
# Copyright (c) 2015 Intel, Inc. All rights reserved.
1515
# Copyright (c) 2017 Los Alamos National Security, LLC. All rights
1616
# reserved.
17+
# Copyright (c) 2019 Hewlett Packard Enterprise. All rights reserved.
1718
# $COPYRIGHT$
1819
#
1920
# Additional copyrights may follow
@@ -28,7 +29,7 @@
2829
# Note that building this common component statically and linking
2930
# against other dynamic components is *not* supported!
3031

31-
AM_CPPFLAGS = $(opal_common_ofi_CPPFLAGS)
32+
AM_CPPFLAGS = $(opal_ofi_CPPFLAGS)
3233

3334
# Header files
3435

@@ -69,13 +70,13 @@ endif
6970

7071
lib@OPAL_LIB_PREFIX@mca_common_ofi_la_SOURCES = $(headers) $(sources)
7172
lib@OPAL_LIB_PREFIX@mca_common_ofi_la_LDFLAGS = \
72-
$(opal_common_ofi_LDFLAGS) \
73+
$(opal_ofi_LDFLAGS) \
7374
-version-info $(libmca_opal_common_ofi_so_version)
74-
lib@OPAL_LIB_PREFIX@mca_common_ofi_la_LIBADD = $(opal_common_ofi_LIBS)
75+
lib@OPAL_LIB_PREFIX@mca_common_ofi_la_LIBADD = $(opal_ofi_LIBS)
7576

7677
lib@OPAL_LIB_PREFIX@mca_common_ofi_noinst_la_SOURCES = $(headers) $(sources)
77-
lib@OPAL_LIB_PREFIX@mca_common_ofi_noinst_la_LDFLAGS = $(opal_common_ofi_LDFLAGS)
78-
lib@OPAL_LIB_PREFIX@mca_common_ofi_noinst_la_LIBADD = $(opal_common_ofi_LIBS)
78+
lib@OPAL_LIB_PREFIX@mca_common_ofi_noinst_la_LDFLAGS = $(opal_ofi_LDFLAGS)
79+
lib@OPAL_LIB_PREFIX@mca_common_ofi_noinst_la_LIBADD = $(opal_ofi_LIBS)
7980

8081
# Conditionally install the header files
8182

opal/mca/common/ofi/configure.m4

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
# Copyright (c) 2015 Cisco Systems, Inc. All rights reserved.
99
# Copyright (c) 2017 Los Alamos National Security, LLC. All rights
1010
# reserved.
11+
# Copyright (c) 2019 Hewlett Packard Enterprise. All rights reserved.
1112
# $COPYRIGHT$
1213
#
1314
# Additional copyrights may follow
@@ -18,15 +19,17 @@
1819
AC_DEFUN([MCA_opal_common_ofi_CONFIG],[
1920
AC_CONFIG_FILES([opal/mca/common/ofi/Makefile])
2021

21-
# Check for ofi. Note that $opal_common_ofi_happy is
22+
OPAL_CHECK_OFI
23+
24+
# Note that $opal_common_ofi_happy is
2225
# used in other configure.m4's to know if ofi configured
2326
# successfully.
24-
OPAL_CHECK_OFI([opal_common_ofi],
25-
[opal_common_ofi_happy=yes
26-
common_ofi_WRAPPER_EXTRA_LDFLAGS=$opal_common_ofi_LDFLAGS
27-
common_ofi_WRAPPER_EXTRA_LIBS=$opal_common_ofi_LIBS
28-
$1],
29-
[opal_common_ofi_happy=no
30-
$2])
27+
AS_IF([test "$opal_ofi_happy" = "yes"],
28+
[opal_common_ofi_happy=yes
29+
common_ofi_WRAPPER_EXTRA_LDFLAGS=$opal_ofi_LDFLAGS
30+
common_ofi_WRAPPER_EXTRA_LIBS=$opal_ofi_LIBS
31+
$1],
32+
[opal_common_ofi_happy=no
33+
$2])
3134

3235
])dnl

0 commit comments

Comments
 (0)