Skip to content

Commit 0e8b35b

Browse files
committed
coll/tuned: use basic algo for reduce_scatter_block by default
Signed-off-by: Gilles Gouaillardet <[email protected]>
1 parent 32095be commit 0e8b35b

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

ompi/mca/coll/tuned/coll_tuned_decision_fixed.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* Copyright (c) 2008 Sun Microsystems, Inc. All rights reserved.
1414
* Copyright (c) 2013 Los Alamos National Security, LLC. All rights
1515
* reserved.
16-
* Copyright (c) 2015 Research Organization for Information Science
16+
* Copyright (c) 2015-2018 Research Organization for Information Science
1717
* and Technology (RIST). All rights reserved.
1818
* $COPYRIGHT$
1919
*
@@ -516,8 +516,8 @@ int ompi_coll_tuned_reduce_scatter_block_intra_dec_fixed(const void *sbuf, void
516516
mca_coll_base_module_t *module)
517517
{
518518
OPAL_OUTPUT((ompi_coll_tuned_stream, "ompi_coll_tuned_reduce_scatter_block_intra_dec_fixed"));
519-
return ompi_coll_base_reduce_scatter_block_intra_recursivedoubling(sbuf, rbuf, rcount,
520-
dtype, op, comm, module);
519+
return ompi_coll_base_reduce_scatter_block_basic(sbuf, rbuf, rcount,
520+
dtype, op, comm, module);
521521
}
522522

523523
/*

ompi/mca/coll/tuned/coll_tuned_reduce_scatter_block_decision.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
/*
33
* Copyright (c) 2018 Siberian State University of Telecommunications
44
* and Information Sciences. All rights reserved.
5+
* Copyright (c) 2018 Research Organization for Information Science
6+
* and Technology (RIST). All rights reserved.
57
* $COPYRIGHT$
68
*
79
* Additional copyrights may follow
@@ -31,7 +33,8 @@ static int coll_tuned_reduce_scatter_block_tree_fanout;
3133
/* valid values for coll_tuned_reduce_scatter_blokc_forced_algorithm */
3234
static mca_base_var_enum_value_t reduce_scatter_block_algorithms[] = {
3335
{0, "ignore"},
34-
{1, "recursive_doubling"},
36+
{1, "basic"},
37+
{2, "recursive_doubling"},
3538
{0, NULL}
3639
};
3740

@@ -118,7 +121,9 @@ int ompi_coll_tuned_reduce_scatter_block_intra_do_this(const void *sbuf, void *r
118121
switch (algorithm) {
119122
case (0): return ompi_coll_tuned_reduce_scatter_block_intra_dec_fixed(sbuf, rbuf, rcount,
120123
dtype, op, comm, module);
121-
case (1): return ompi_coll_base_reduce_scatter_block_intra_recursivedoubling(sbuf, rbuf, rcount,
124+
case (1): return ompi_coll_base_reduce_scatter_block_basic(sbuf, rbuf, rcount,
125+
dtype, op, comm, module);
126+
case (2): return ompi_coll_base_reduce_scatter_block_intra_recursivedoubling(sbuf, rbuf, rcount,
122127
dtype, op, comm, module);
123128
} /* switch */
124129
OPAL_OUTPUT((ompi_coll_tuned_stream, "coll:tuned:reduce_scatter_block_intra_do_this attempt to select algorithm %d when only 0-%d is valid?",

0 commit comments

Comments
 (0)