Skip to content

Commit 15ad7d8

Browse files
authored
Merge pull request #10580 from MamziB/mamzi/dyn-win-3
OSC/UCX Dynamic window fixes
2 parents c6dca98 + 6233e0d commit 15ad7d8

File tree

7 files changed

+142
-177
lines changed

7 files changed

+142
-177
lines changed

ompi/mca/osc/ucx/osc_ucx.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#define OSC_UCX_VERBOSE MCA_COMMON_UCX_VERBOSE
2525

2626
#define OMPI_OSC_UCX_POST_PEER_MAX 32
27-
#define OMPI_OSC_UCX_ATTACH_MAX 32
27+
#define OMPI_OSC_UCX_ATTACH_MAX 48
2828
#define OMPI_OSC_UCX_MEM_ADDR_MAX_LEN 1024
2929

3030
typedef struct ompi_osc_ucx_component {

ompi/mca/osc/ucx/osc_ucx_active_target.c

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -74,20 +74,9 @@ int ompi_osc_ucx_fence(int mpi_assert, struct ompi_win_t *win) {
7474
}
7575

7676
if (!(mpi_assert & MPI_MODE_NOPRECEDE)) {
77-
if (module->flavor == MPI_WIN_FLAVOR_DYNAMIC) {
78-
int i;
79-
for (i = 0; i < OMPI_OSC_UCX_ATTACH_MAX; i++) {
80-
ret = opal_common_ucx_wpmem_flush(module->local_dynamic_win_info[i].mem,
81-
OPAL_COMMON_UCX_SCOPE_WORKER, 0/*ignore*/);
82-
if (ret != OMPI_SUCCESS) {
83-
return ret;
84-
}
85-
}
86-
} else {
87-
ret = opal_common_ucx_wpmem_flush(module->mem, OPAL_COMMON_UCX_SCOPE_WORKER, 0/*ignore*/);
88-
if (ret != OMPI_SUCCESS) {
89-
return ret;
90-
}
77+
ret = opal_common_ucx_ctx_flush(module->ctx, OPAL_COMMON_UCX_SCOPE_WORKER, 0/*ignore*/);
78+
if (ret != OMPI_SUCCESS) {
79+
return ret;
9180
}
9281
}
9382

@@ -183,7 +172,7 @@ int ompi_osc_ucx_complete(struct ompi_win_t *win) {
183172

184173
module->epoch_type.access = NONE_EPOCH;
185174

186-
ret = opal_common_ucx_wpmem_flush(module->mem, OPAL_COMMON_UCX_SCOPE_WORKER, 0/*ignore*/);
175+
ret = opal_common_ucx_ctx_flush(module->ctx, OPAL_COMMON_UCX_SCOPE_WORKER, 0/*ignore*/);
187176
if (ret != OMPI_SUCCESS) {
188177
return ret;
189178
}
@@ -199,7 +188,7 @@ int ompi_osc_ucx_complete(struct ompi_win_t *win) {
199188
OSC_UCX_VERBOSE(1, "opal_common_ucx_mem_post failed: %d", ret);
200189
}
201190

202-
ret = opal_common_ucx_wpmem_flush(module->state_mem, OPAL_COMMON_UCX_SCOPE_EP,
191+
ret = opal_common_ucx_ctx_flush(module->ctx, OPAL_COMMON_UCX_SCOPE_EP,
203192
module->start_grp_ranks[i]);
204193
if (ret != OMPI_SUCCESS) {
205194
return ret;

0 commit comments

Comments
 (0)