Skip to content

Commit 17d8ba0

Browse files
committed
Silence trivial warning
Update PMIx/PRRTE pointers Signed-off-by: Ralph Castain <[email protected]>
1 parent e813ad3 commit 17d8ba0

File tree

7 files changed

+20
-19
lines changed

7 files changed

+20
-19
lines changed

3rd-party/prrte

Submodule prrte updated 239 files

config/ompi_setup_prrte.m4

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
# Copyright (c) 2019-2020 Intel, Inc. All rights reserved.
1919
# Copyright (c) 2020 Amazon.com, Inc. or its affiliates.
2020
# All Rights reserved.
21+
# Copyright (c) 2021 Nanook Consulting. All rights reserved.
2122
# $COPYRIGHT$
2223
#
2324
# Additional copyrights may follow
@@ -143,6 +144,10 @@ AC_DEFUN([OMPI_SETUP_PRRTE_INTERNAL], [
143144
[internal_prrte_args="--enable-prte-ft $internal_prrte_args"],
144145
[])
145146

147+
if test "$WANT_DEBUG" = "1"; then
148+
internal_prrte_args="$internal_prrte_args --enable-debug"
149+
fi
150+
146151
# Pass all our compiler/linker flags to PRRTE, so that it
147152
# picks up how to build an internal HWLOC, libevent, and PMIx, plus
148153
# picks up any user-specified compiler flags from the master

config/opal_config_pmix.m4

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ dnl Copyright (c) 2020 Triad National Security, LLC. All rights
2121
dnl reserved.
2222
dnl Copyright (c) 2020 Amazon.com, Inc. or its affiliates. All Rights
2323
dnl reserved.
24+
dnl Copyright (c) 2021 Nanook Consulting. All rights reserved.
2425
dnl $COPYRIGHT$
2526
dnl
2627
dnl Additional copyrights may follow
@@ -86,6 +87,10 @@ AC_DEFUN([OPAL_CONFIG_PMIX], [
8687
AS_IF([test ! -z "$internal_pmix_libs"],
8788
[internal_pmix_args="$internal_pmix_args --with-prte-extra-lib=\"$internal_pmix_libs\""])
8889
90+
if test "$WANT_DEBUG" = "1"; then
91+
internal_pmix_args="$internal_pmix_args --enable-debug"
92+
fi
93+
8994
# Pass all our compiler/linker flags to PMIx, so that it
9095
# picks up how to build an internal HWLOC and libevent, plus
9196
# picks up any user-specified compiler flags from the master

opal/mca/base/mca_base_var.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
* Copyright (c) 2018 Triad National Security, LLC. All rights
2222
* reserved.
2323
* Copyright (c) 2020 Google, LLC. All rights reserved.
24+
* Copyright (c) 2021 Nanook Consulting. All rights reserved.
2425
* $COPYRIGHT$
2526
*
2627
* Additional copyrights may follow
@@ -417,6 +418,7 @@ int mca_base_var_load_extra_files(char* files, bool rel_path_search) {
417418
resolve_relative_paths(&tmp1, mca_base_param_file_path, rel_path_search, &mca_base_var_files, OPAL_ENV_SEP);
418419
read_files (tmp1, &mca_base_var_file_values, ',');
419420
free(tmp1);
421+
return OPAL_SUCCESS;
420422
}
421423

422424
int mca_base_var_cache_files(bool rel_path_search)

opal/mca/pmix/base/pmix_base_fns.c

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
* Copyright (c) 2016 Mellanox Technologies, Inc.
99
* All rights reserved.
1010
* Copyright (c) 2016 Cisco Systems, Inc. All rights reserved.
11+
* Copyright (c) 2021 Nanook Consulting. All rights reserved.
1112
* $COPYRIGHT$
1213
*
1314
* Additional copyrights may follow
@@ -131,25 +132,13 @@ int opal_pmix_convert_nspace(opal_jobid_t *jobid, pmix_nspace_t nspace)
131132

132133
/* set a default */
133134
if (NULL != jobid) {
134-
*jobid = OPAL_JOBID_INVALID;
135+
*jobid = OPAL_JOBID_WILDCARD;
135136
}
136137

137138
/* if the nspace is empty, there is nothing more to do */
138139
if (0 == strlen(nspace)) {
139140
return OPAL_SUCCESS;
140141
}
141-
if (NULL != strstr(nspace, "JOBID_WILDCARD")) {
142-
if (NULL != jobid) {
143-
*jobid = OPAL_JOBID_WILDCARD;
144-
}
145-
return OPAL_SUCCESS;
146-
}
147-
if (NULL != strstr(nspace, "JOBID_INVALID")) {
148-
if (NULL != jobid) {
149-
*jobid = OPAL_JOBID_INVALID;
150-
}
151-
return OPAL_SUCCESS;
152-
}
153142

154143
/* cycle across our list of known nspace's */
155144
OPAL_LIST_FOREACH(nptr, &localnspaces, opal_nptr_t) {
@@ -163,12 +152,12 @@ int opal_pmix_convert_nspace(opal_jobid_t *jobid, pmix_nspace_t nspace)
163152

164153
/* if we get here, we don't know this nspace */
165154
/* find the "." at the end that indicates the child job */
166-
if (NULL != (p = strrchr(nspace, '.'))) {
155+
if (NULL != (p = strrchr(nspace, '@'))) {
167156
*p = '\0';
168157
}
169158
OPAL_HASH_STR(nspace, hash32);
170159
if (NULL != p) {
171-
*p = '.';
160+
*p = '@';
172161
++p;
173162
localjob = strtoul(p, NULL, 10);
174163
}

test/simple/intercomm_create.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ void ompitest_warning( char* filename, int lineno, const char* fmt, ... )
2323
va_list va_list;
2424

2525
va_start(va_list, fmt);
26-
opal_vasprintf( &buf, fmt, va_list );
26+
vasprintf( &buf, fmt, va_list );
2727
va_end(va_list);
2828
printf( "*warning* %s:%d %s\n", filename, lineno, buf );
2929
free(buf);
@@ -35,7 +35,7 @@ void ompitest_error( char* filename, int lineno, const char* fmt, ... )
3535
va_list va_list;
3636

3737
va_start(va_list, fmt);
38-
opal_vasprintf( &buf, fmt, va_list );
38+
vasprintf( &buf, fmt, va_list );
3939
va_end(va_list);
4040
printf( "*error* %s:%d %s\n", filename, lineno, buf );
4141
free(buf);

0 commit comments

Comments
 (0)