Skip to content

Commit 1ea8fab

Browse files
bosilcabosilca
committed
Make external symbols visible.
All symbols that need to be accessed from a MCA component must be marked explicitly as visible using PMIX_EXPORT. This patch allows current trunk to almost work on OsX. More on the devel mailing list. Signed-off-by: George Bosilca <[email protected]>
1 parent e054f87 commit 1ea8fab

File tree

8 files changed

+24
-24
lines changed

8 files changed

+24
-24
lines changed

‎opal/mca/pmix/pmix2x/pmix/src/class/pmix_hash_table.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747

4848
BEGIN_C_DECLS
4949

50-
PMIX_CLASS_DECLARATION(pmix_hash_table_t);
50+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_hash_table_t);
5151

5252
struct pmix_hash_table_t
5353
{

‎opal/mca/pmix/pmix2x/pmix/src/class/pmix_list.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,13 @@ BEGIN_C_DECLS
8383
*
8484
* The class for the list container.
8585
*/
86-
PMIX_CLASS_DECLARATION(pmix_list_t);
86+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_list_t);
8787
/**
8888
* \internal
8989
*
9090
* Base class for items that are put in list (pmix_list_t) containers.
9191
*/
92-
PMIX_CLASS_DECLARATION(pmix_list_item_t);
92+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_list_item_t);
9393

9494

9595
/**

‎opal/mca/pmix/pmix2x/pmix/src/class/pmix_value_array.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ struct pmix_value_array_t
4949
};
5050
typedef struct pmix_value_array_t pmix_value_array_t;
5151

52-
PMIX_CLASS_DECLARATION(pmix_value_array_t);
52+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_value_array_t);
5353

5454
/**
5555
* Initialize the array to hold items by value. This routine must

‎opal/mca/pmix/pmix2x/pmix/src/mca/base/pmix_mca_base_framework.h‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ typedef struct pmix_mca_base_framework_t {
169169
*
170170
* Call a framework's register function.
171171
*/
172-
int pmix_mca_base_framework_register (pmix_mca_base_framework_t *framework,
173-
pmix_mca_base_register_flag_t flags);
172+
PMIX_EXPORT int pmix_mca_base_framework_register (pmix_mca_base_framework_t *framework,
173+
pmix_mca_base_register_flag_t flags);
174174

175175
/**
176176
* Open a framework
@@ -182,8 +182,8 @@ int pmix_mca_base_framework_register (pmix_mca_base_framework_t *framework,
182182
*
183183
* Call a framework's open function.
184184
*/
185-
int pmix_mca_base_framework_open (pmix_mca_base_framework_t *framework,
186-
pmix_mca_base_open_flag_t flags);
185+
PMIX_EXPORT int pmix_mca_base_framework_open (pmix_mca_base_framework_t *framework,
186+
pmix_mca_base_open_flag_t flags);
187187

188188
/**
189189
* Close a framework
@@ -195,7 +195,7 @@ int pmix_mca_base_framework_open (pmix_mca_base_framework_t *framework,
195195
*
196196
* Call a framework's close function.
197197
*/
198-
int pmix_mca_base_framework_close (pmix_mca_base_framework_t *framework);
198+
PMIX_EXPORT int pmix_mca_base_framework_close (pmix_mca_base_framework_t *framework);
199199

200200

201201
/**
@@ -206,7 +206,7 @@ int pmix_mca_base_framework_close (pmix_mca_base_framework_t *framework);
206206
* @retval true if the framework's mca variables are registered
207207
* @retval false if not
208208
*/
209-
bool pmix_mca_base_framework_is_registered (struct pmix_mca_base_framework_t *framework);
209+
PMIX_EXPORT bool pmix_mca_base_framework_is_registered (struct pmix_mca_base_framework_t *framework);
210210

211211

212212
/**
@@ -217,7 +217,7 @@ bool pmix_mca_base_framework_is_registered (struct pmix_mca_base_framework_t *fr
217217
* @retval true if the framework is open
218218
* @retval false if not
219219
*/
220-
bool pmix_mca_base_framework_is_open (struct pmix_mca_base_framework_t *framework);
220+
PMIX_EXPORT bool pmix_mca_base_framework_is_open (struct pmix_mca_base_framework_t *framework);
221221

222222

223223
/**

‎opal/mca/pmix/pmix2x/pmix/src/mca/bfrops/base/base.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ PMIX_EXPORT extern pmix_bfrops_globals_t pmix_bfrops_globals;
177177
/** prpmix_status_t function */
178178
pmix_bfrop_print_fn_t odti_print_fn;
179179
} pmix_bfrop_type_info_t;
180-
PMIX_CLASS_DECLARATION(pmix_bfrop_type_info_t);
180+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_bfrop_type_info_t);
181181

182182
/* macro for registering data types - overwrite an existing
183183
* duplicate one based on type name */

‎opal/mca/pmix/pmix2x/pmix/src/mca/bfrops/bfrops_types.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ typedef struct {
6464
char *key;
6565
pmix_value_t *value;
6666
} pmix_kval_t;
67-
PMIX_CLASS_DECLARATION(pmix_kval_t);
67+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_kval_t);
6868

6969

7070
/**
@@ -89,7 +89,7 @@ typedef struct {
8989
including overhead -- packed in the buffer) */
9090
size_t bytes_used;
9191
} pmix_buffer_t;
92-
PMIX_CLASS_DECLARATION(pmix_buffer_t);
92+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_buffer_t);
9393

9494
/* Convenience macro for loading a data blob into a pmix_buffer_t
9595
*

‎opal/mca/pmix/pmix2x/pmix/src/mca/preg/preg_types.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ typedef struct {
4242
int start;
4343
int cnt;
4444
} pmix_regex_range_t;
45-
PMIX_CLASS_DECLARATION(pmix_regex_range_t);
45+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_regex_range_t);
4646

4747
typedef struct {
4848
/* list object */
@@ -52,7 +52,7 @@ typedef struct {
5252
int num_digits;
5353
pmix_list_t ranges;
5454
} pmix_regex_value_t;
55-
PMIX_CLASS_DECLARATION(pmix_regex_value_t);
55+
PMIX_EXPORT PMIX_CLASS_DECLARATION(pmix_regex_value_t);
5656

5757
END_C_DECLS
5858

‎opal/mca/pmix/pmix2x/pmix/src/util/hash.h‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,21 @@ BEGIN_C_DECLS
2424

2525
/* store a value in the given hash table for the specified
2626
* rank index.*/
27-
pmix_status_t pmix_hash_store(pmix_hash_table_t *table,
28-
pmix_rank_t rank, pmix_kval_t *kv);
27+
PMIX_EXPORT pmix_status_t pmix_hash_store(pmix_hash_table_t *table,
28+
pmix_rank_t rank, pmix_kval_t *kv);
2929

3030
/* Fetch the value for a specified key and rank from within
3131
* the given hash_table */
32-
pmix_status_t pmix_hash_fetch(pmix_hash_table_t *table, pmix_rank_t rank,
33-
const char *key, pmix_value_t **kvs);
32+
PMIX_EXPORT pmix_status_t pmix_hash_fetch(pmix_hash_table_t *table, pmix_rank_t rank,
33+
const char *key, pmix_value_t **kvs);
3434

3535
/* Fetch the value for a specified key from within
3636
* the given hash_table
3737
* It gets the next portion of data from table, where matching key.
3838
* To get the first data from table, function is called with key parameter as string.
3939
* Remaining data from table are obtained by calling function with a null pointer for the key parameter.*/
40-
pmix_status_t pmix_hash_fetch_by_key(pmix_hash_table_t *table, const char *key,
41-
pmix_rank_t *rank, pmix_value_t **kvs, void **last);
40+
PMIX_EXPORT pmix_status_t pmix_hash_fetch_by_key(pmix_hash_table_t *table, const char *key,
41+
pmix_rank_t *rank, pmix_value_t **kvs, void **last);
4242

4343
/* remove the specified key-value from the given hash_table.
4444
* A NULL key will result in removal of all data for the
@@ -47,8 +47,8 @@ pmix_status_t pmix_hash_fetch_by_key(pmix_hash_table_t *table, const char *key,
4747
* ranks in the table. Combining key=NULL with rank=PMIX_RANK_WILDCARD
4848
* will therefore result in removal of all data from the
4949
* table */
50-
pmix_status_t pmix_hash_remove_data(pmix_hash_table_t *table,
51-
pmix_rank_t rank, const char *key);
50+
PMIX_EXPORT pmix_status_t pmix_hash_remove_data(pmix_hash_table_t *table,
51+
pmix_rank_t rank, const char *key);
5252

5353
END_C_DECLS
5454

0 commit comments

Comments
 (0)