Some minor cleanups of a memory leak and error output

Author: Ralph Castain

opal/mca/pmix/pmix120/pmix/src/server/pmix_server.c

@@ -225,9 +225,11 @@ static pmix_status_t initialize_server_base(pmix_server_module_t *module)
     // plus the '/' separator are too long, just fail, so the caller
     // may provide the user with a proper help... *Cough*, *Cough* OSX...
     if ((strlen(tdir) + strlen(pmix_pid) + 1) > sizeof(myaddress.sun_path)-1) {
+        free(pmix_pid);
         return PMIX_ERR_INVALID_LENGTH;
     }
     snprintf(myaddress.sun_path, sizeof(myaddress.sun_path)-1, "%s/%s", tdir, pmix_pid);
+    free(pmix_pid);
     asprintf(&myuri, "%s:%lu:%s", pmix_globals.myid.nspace, (unsigned long)pmix_globals.myid.rank, myaddress.sun_path);
 
 

orte/mca/ess/base/ess_base_std_orted.c

@@ -514,8 +514,9 @@ int orte_ess_base_orted_setup(char **hosts)
     opal_pmix_base_set_evbase(orte_event_base);
     /* setup the PMIx server */
     if (ORTE_SUCCESS != (ret = pmix_server_init())) {
-        ORTE_ERROR_LOG(ret);
-        error = "Try a shorter TMPDIR var. or change your computer's name (see uname -n), since pmix_server_init";
+        /* the server code already barked, so let's be quiet */
+        ret = ORTE_ERR_SILENT;
+        error = "pmix_server_init";
         goto error;
     }
 

orte/mca/ess/hnp/ess_hnp_module.c

@@ -633,8 +633,9 @@ static int rte_init(void)
 
     /* setup the PMIx server */
     if (ORTE_SUCCESS != (ret = pmix_server_init())) {
-        ORTE_ERROR_LOG(ret);
-        error = "Try a shorter TMPDIR var. or change your computer's name (see uname -n), since pmix_server_init";
+        /* the server code already barked, so let's be quiet */
+        ret = ORTE_ERR_SILENT;
+        error = "pmix_server_init";
         goto error;
     }