osc/rdma: Detect unsupported data types and abort

  Using MPI_MINLOC or MPI_MAXLOC with the following data types
  leads to data corruption:
   * MPI_DOUBLE_INT
   * MPI_LONG_INT
   * MPI_SHORT_INT
   * MPI_LONG_DOUBLE_INT

  Detect this print a error message and abort.
  This workaround should be removed once the following issue is resolved:
   * #1666

Signed-off-by: Joshua Hursey <[email protected]>

Author: jjhursey

ompi/mca/osc/rdma/osc_rdma_accumulate.c

@@ -2,6 +2,7 @@
 /*
  * Copyright (c) 2014-2015 Los Alamos National Security, LLC.  All rights
  *                         reserved.
+ * Copyright (c) 2017 IBM Corporation.  All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -12,6 +13,7 @@
 #include "osc_rdma_accumulate.h"
 #include "osc_rdma_request.h"
 #include "osc_rdma_comm.h"
+#include "opal/util/show_help.h"
 
 #include "ompi/mca/osc/base/osc_base_obj_convert.h"
 
@@ -753,6 +755,46 @@ int ompi_osc_rdma_rget_accumulate_internal (ompi_osc_rdma_sync_t *sync, const vo
         return OMPI_SUCCESS;
     }
 
+    /* TODO: Remove the following check when support is added.
+     * See the following issue for the current state:
+     *   https://github.com/open-mpi/ompi/issues/1666
+     */
+    if(MPI_MINLOC == op || MPI_MAXLOC == op) {
+        if(MPI_SHORT_INT == origin_datatype ||
+           MPI_DOUBLE_INT == origin_datatype ||
+           MPI_LONG_INT == origin_datatype ||
+           MPI_LONG_DOUBLE_INT == origin_datatype) {
+           ompi_communicator_t *comm = &ompi_mpi_comm_world.comm;
+           opal_show_help("help-mca-osc-base.txt", "unsupported-dt", true,
+                          origin_datatype->name,
+                          op->o_name,
+                          comm->c_my_rank);
+           ompi_mpi_abort(comm, -1);
+        }
+        if(MPI_SHORT_INT == result_datatype ||
+           MPI_DOUBLE_INT == result_datatype ||
+           MPI_LONG_INT == result_datatype ||
+           MPI_LONG_DOUBLE_INT == result_datatype) {
+           ompi_communicator_t *comm = &ompi_mpi_comm_world.comm;
+           opal_show_help("help-mca-osc-base.txt", "unsupported-dt", true,
+                          result_datatype->name,
+                          op->o_name,
+                          comm->c_my_rank);
+           ompi_mpi_abort(comm, -1);
+        }
+        if(MPI_SHORT_INT == target_datatype ||
+           MPI_DOUBLE_INT == target_datatype ||
+           MPI_LONG_INT == target_datatype ||
+           MPI_LONG_DOUBLE_INT == target_datatype) {
+           ompi_communicator_t *comm = &ompi_mpi_comm_world.comm;
+           opal_show_help("help-mca-osc-base.txt", "unsupported-dt", true,
+                          target_datatype->name,
+                          op->o_name,
+                          comm->c_my_rank);
+           ompi_mpi_abort(comm, -1);
+        }
+    }
+
     ret = osc_rdma_get_remote_segment (module, peer, target_disp, target_datatype->super.size * target_count,
                                        &target_address, &target_handle);
     if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {