Skip to content

Commit 2beacdc

Browse files
author
Valentin Petrov
committed
Fixes the coll_allgather usage bug
One should use the correct module object when calling c_coll.coll_allgather. Otherwise there will be a segfault in the case, for example, when hcoll is used. In that case c_coll.coll_allgather = mca_coll_hcoll_allgather while c_coll.coll_gather_module = tuned. Signed-off-by: Valentin Petrov <[email protected]>
1 parent 82becce commit 2beacdc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ompi/mca/osc/rdma/osc_rdma_component.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,7 @@ static int ompi_osc_rdma_share_data (ompi_osc_rdma_module_t *module)
856856
if (ompi_comm_size (module->local_leaders) > 1) {
857857
ret = module->local_leaders->c_coll.coll_allgather (MPI_IN_PLACE, module->region_size, MPI_BYTE, module->node_comm_info,
858858
module->region_size, MPI_BYTE, module->local_leaders,
859-
module->local_leaders->c_coll.coll_gather_module);
859+
module->local_leaders->c_coll.coll_allgather_module);
860860
if (OMPI_SUCCESS != ret) {
861861
OSC_RDMA_VERBOSE(MCA_BASE_VERBOSE_ERROR, "leader allgather failed with ompi error code %d", ret);
862862
break;

0 commit comments

Comments
 (0)