build: Add build mode check for common libraries

Add a macro OPAL_MCA_CHECK_DEPENDENCY() to check if a component's
build mode (static / dso) conflicts with a dependent component's
build mode (generally, a common library).  The issue of concern
is if the component is built as a static component, but the
common component is build as a dso.  Since all the common components
currently depend on libopen-pal (and sometimes libmpi), libopen-pal
and/or libmpi cannot depend on a common library without creating a
circular dependency chain, and we do not like those.

Signed-off-by: Brian Barrett <[email protected]>

Author: bwbarrett

config/opal_mca.m4

@@ -1033,3 +1033,29 @@ AC_DEFUN([OPAL_MCA_MAKE_DIR_LIST],[
     done
     AC_SUBST($1)
 ])
+
+
+# OPAL_MCA_CHECK_DEPENDENCY(check project, check framework, check component,
+#                           dependent project, dependent framework, dependent component)
+# --------------------------------------------------------------------------
+# Enforce that the check component does not introduce a dependency from its
+# project library (ie libmpi.so or libopen-pal.so) to another component
+# (ie, a common_*.so).  This can happen if the check component is set to
+# build static and the common library is set to build dso.  If this situation
+# is detected, print an error and abort configure.
+AC_DEFUN([OPAL_MCA_CHECK_DEPENDENCY],
+[
+    OPAL_VAR_SCOPE_PUSH([component_compile_mode dependency_compile_mode])
+
+    MCA_COMPONENT_COMPILE_MODE([$1], [$2], [$3], [component_compile_mode])
+    MCA_COMPONENT_COMPILE_MODE([$4], [$5], [$6], [dependency_compile_mode])
+
+    AS_IF([test "${component_compile_mode}" = "static" -a "${dependency_compile_mode}" = "dso"],
+         [AC_MSG_ERROR([Component $2:$3 is set to build as a
+static component, but its dependency $5:$6 is set to build as
+a dynamic component.  This configuration is not supported.  Please
+either build $5:$6 as a static component or build $2:$3 as a dynamic
+component.])])
+
+    OPAL_VAR_SCOPE_POP
+])

ompi/mca/coll/sm/configure.m4

@@ -0,0 +1,17 @@
+# -*- autoconf -*-
+#
+# Copyright (c) 2022      Amazon.com, Inc. or its affiliates.  All Rights reserved.
+# $COPYRIGHT$
+#
+# Additional copyrights may follow
+#
+# $HEADER$
+#
+
+AC_DEFUN([MCA_ompi_coll_sm_CONFIG],[
+    AC_CONFIG_FILES([ompi/mca/coll/sm/Makefile])
+
+    OPAL_MCA_CHECK_DEPENDENCY([ompi], [coll], [sm], [opal], [common], [sm])
+
+    $1
+])dnl

ompi/mca/mtl/ofi/configure.m4

@@ -48,6 +48,9 @@ AC_DEFUN([MCA_ompi_mtl_ofi_CONFIG],[
                                             [],
                                             [mtl_ofi_happy=0])])])
 
+    AS_IF([test ${mtl_ofi_happy} -eq 1],
+          [OPAL_MCA_CHECK_DEPENDENCY([opal], [btl], [ofi], [opal], [common], [ofi])])
+
     AS_IF([test ${mtl_ofi_happy} -eq 1],
           [$1],
           [AS_IF([test -n "${with_ofi}" -a "${with_ofi}" != "no"],

ompi/mca/osc/ucx/configure.m4

@@ -1,6 +1,7 @@
 # -*- shell-script -*-
 #
 # Copyright (C) Mellanox Technologies Ltd. 2001-2017.  ALL RIGHTS RESERVED.
+# Copyright (c) 2022      Amazon.com, Inc. or its affiliates.  All Rights reserved.
 # $COPYRIGHT$
 #
 # Additional copyrights may follow
@@ -25,6 +26,9 @@ AC_DEFUN([MCA_ompi_osc_ucx_CONFIG],[
                    [osc_ucx_happy="yes"],
                    [osc_ucx_happy="no"])
 
+    AS_IF([test "${osc_ucx_happy}" = "yes"],
+          [OPAL_MCA_CHECK_DEPENDENCY([ompi], [osc], [ucx], [opal], [common], [ucx])])
+
     AS_IF([test "$osc_ucx_happy" = "yes"],
           [$1],
           [$2])

ompi/mca/pml/ucx/configure.m4

@@ -1,5 +1,6 @@
 #
 # Copyright (C) Mellanox Technologies Ltd. 2001-2015.  ALL RIGHTS RESERVED.
+# Copyright (c) 2022      Amazon.com, Inc. or its affiliates.  All Rights reserved.
 # $COPYRIGHT$
 #
 # Additional copyrights may follow
@@ -19,6 +20,9 @@ AC_DEFUN([MCA_ompi_pml_ucx_CONFIG], [
                    [pml_ucx_happy="yes"],
                    [pml_ucx_happy="no"])
 
+    AS_IF([test "${pml_ucx_happy}" = "yes"],
+          [OPAL_MCA_CHECK_DEPENDENCY([ompi], [pml], [ucx], [opal], [common], [ucx])])
+
     AS_IF([test "$pml_ucx_happy" = "yes"],
           [$1],
           [$2])

opal/mca/btl/ofi/configure.m4

@@ -15,7 +15,6 @@
 # Copyright (c) 2011-2018 Los Alamos National Security, LLC.
 #                         All rights reserved.
 # Copyright (c) 2018      Intel, inc. All rights reserved
-#
 # Copyright (c) 2022      Amazon.com, Inc. or its affiliates.  All Rights reserved.
 # $COPYRIGHT$
 #
@@ -45,6 +44,9 @@ AC_DEFUN([MCA_opal_btl_ofi_CONFIG],[
                          [#include <rdma/fabric.h>])
            CPPFLAGS=${CPPFLAGS_save}])
 
+    AS_IF([test ${btl_ofi_happy} -eq 1],
+          [OPAL_MCA_CHECK_DEPENDENCY([opal], [btl], [ofi], [opal], [common], [ofi])])
+
     AS_IF([test ${btl_ofi_happy} -eq 1],
           [$1],
           [AS_IF([test -n "${with_ofi}" -a "${with_ofi}" != "no"],

opal/mca/btl/smcuda/configure.m4

@@ -5,6 +5,7 @@
 #                         reserved.
 # Copyright (c) 2009-2010 Cisco Systems, Inc.  All rights reserved.
 # Copyright (c) 2012-2015 NVIDIA Corporation.  All rights reserved.
+# Copyright (c) 2022      Amazon.com, Inc. or its affiliates.  All Rights reserved.
 # $COPYRIGHT$
 #
 # Additional copyrights may follow
@@ -23,7 +24,7 @@ AC_DEFUN([MCA_opal_btl_smcuda_CONFIG],[
 
     # Only build if CUDA support is available
     AS_IF([test "x$CUDA_SUPPORT" = "x1"],
-          [$1],
+          [$1
+           OPAL_MCA_CHECK_DEPENDENCY([opal], [btl], [smcuda], [opal], [common], [sm])],
           [$2])
-
 ])dnl