Merge pull request #3100 from artpol84/fix_ucx_req/master

mike-dubman · web-flow · commit 2f8c759b733d · 2017-03-05T08:53:18.000+01:00
ompi/pml/ucx: Fix uninitialized UCX request field.
diff --git a/ompi/mca/pml/ucx/pml_ucx_request.c b/ompi/mca/pml/ucx/pml_ucx_request.c
@@ -166,7 +166,8 @@ static int mca_pml_ucx_persistent_request_free(ompi_request_t **rptr)
         mca_pml_ucx_persistent_request_detach(preq, tmp_req);
         ucp_request_free(tmp_req);
     }
-    if (MCA_PML_BASE_SEND_BUFFERED == preq->send.mode) {
+    if ((preq->flags & MCA_PML_UCX_REQUEST_FLAG_SEND) &&
+         (MCA_PML_BASE_SEND_BUFFERED == preq->send.mode)) {
         OBJ_RELEASE(preq->ompi_datatype);
     }
     PML_UCX_FREELIST_RETURN(&ompi_pml_ucx.persistent_reqs, &preq->ompi.super);

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,8 @@ static int mca_pml_ucx_persistent_request_free(ompi_request_t **rptr)`
`166`	`166`	`mca_pml_ucx_persistent_request_detach(preq, tmp_req);`
`167`	`167`	`ucp_request_free(tmp_req);`
`168`	`168`	`}`
`169`		`- if (MCA_PML_BASE_SEND_BUFFERED == preq->send.mode) {`
	`169`	`+ if ((preq->flags & MCA_PML_UCX_REQUEST_FLAG_SEND) &&`
	`170`	`+ (MCA_PML_BASE_SEND_BUFFERED == preq->send.mode)) {`
`170`	`171`	`OBJ_RELEASE(preq->ompi_datatype);`
`171`	`172`	`}`
`172`	`173`	`PML_UCX_FREELIST_RETURN(&ompi_pml_ucx.persistent_reqs, &preq->ompi.super);`