Skip to content

Commit 36b64cb

Browse files
author
Valentin Petrov
committed
PML/UCX: don't do pml_check_selected call
Current implementation of pml check protocol causes extra dmodex exchanges that may result in a significant performance degradation for some workloads Signed-off-by: Valentin Petrov <[email protected]>
1 parent ef7fdbf commit 36b64cb

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

ompi/mca/pml/ucx/pml_ucx.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -417,13 +417,6 @@ int mca_pml_ucx_add_procs(struct ompi_proc_t **procs, size_t nprocs)
417417
ompi_proc_t *proc;
418418
ucp_ep_h ep;
419419
size_t i;
420-
int ret;
421-
422-
if (OMPI_SUCCESS != (ret = mca_pml_base_pml_check_selected("ucx",
423-
procs,
424-
nprocs))) {
425-
return ret;
426-
}
427420

428421
for (i = 0; i < nprocs; ++i) {
429422
proc = procs[(i + OMPI_PROC_MY_NAME->vpid) % nprocs];
@@ -448,13 +441,6 @@ static inline ucp_ep_h mca_pml_ucx_get_ep(ompi_communicator_t *comm, int rank)
448441
return ep;
449442
}
450443

451-
/* Note, mca_pml_base_pml_check_selected, doesn't use 3rd argument */
452-
if (OMPI_SUCCESS != mca_pml_base_pml_check_selected("ucx",
453-
&proc_peer,
454-
1)) {
455-
return NULL;
456-
}
457-
458444
return mca_pml_ucx_add_proc_common(proc_peer);
459445
}
460446

0 commit comments

Comments
 (0)